DojoUtils class improvement needed

[Zdeněk Sochor <zd...@ataco.cz>]

Hi,
  by looking at org.apache.myfaces.custom.dojoDojoUtils class i found 1 
issue, which could block extending usability of dojo.
Problem is in static method getAttributeMap(FacesContext, String[] , 
UIComponent):
- it doesn't count with preferred way of declaring get methods dealing 
with booleans (isAttribute() instead of getAttribute()).

Zdenek

Re: DojoUtils class improvement needed

[Werner Punz <we...@gmail.com>]

Zdeněk Sochor schrieb:
> Hi,
>  by looking at org.apache.myfaces.custom.dojoDojoUtils class i found 1
> issue, which could block extending usability of dojo.
> Problem is in static method getAttributeMap(FacesContext, String[] ,
> UIComponent):
> - it doesn't count with preferred way of declaring get methods dealing
> with booleans (isAttribute() instead of getAttribute()).
> 
Actually I added this comment as well to the issue.
First of all thanks for the patch it is in the codebase.
Such issues always are the best we have way too few of them.

There was a reason why I did not implement the reflection for the
is<xxx> property Methods.
It is not clear from the viewpoint of the DojoUtils, but when I wrote
the code (bear in mind it has been a long time ago) I basically went
for java objects not native types, is<xxx> is not common on
java.lang.Boolean only for boolean.

But after reading your patch and thinking things over, it makes sense
to cover is<..> as well for property accessors.
First of all things move slowly but steadily towards jdk 5 where
the line between Objects and native types finally becomes more blurred
so we will probably see is on Boolean values more often.

Secondly it simply makes sense to cover it because all property accessor
methods have to be covered.

So to sum it up, thanks for the patch, I just committed it.

Werner

Re: DojoUtils class improvement needed

[Matthias Wessendorf <ma...@apache.org>]

please file a jira issue so we don't loose this issue.
and to speed up things, providing a fix is appreciated ;)

On 2/23/07, Zdeněk Sochor <zd...@ataco.cz> wrote:
> Hi,
>   by looking at org.apache.myfaces.custom.dojoDojoUtils class i found 1
> issue, which could block extending usability of dojo.
> Problem is in static method getAttributeMap(FacesContext, String[] ,
> UIComponent):
> - it doesn't count with preferred way of declaring get methods dealing
> with booleans (isAttribute() instead of getAttribute()).
>
> Zdenek
>


-- 
Matthias Wessendorf
http://tinyurl.com/fmywh

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com