You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/08 08:17:02 UTC
[GitHub] [cloudstack] utchoang opened a new pull request #4769: UI: Save and auto-expand list domain when reloading
utchoang opened a new pull request #4769:
URL: https://github.com/apache/cloudstack/pull/4769
### Description
Related https://github.com/apache/cloudstack/pull/4762
This PR for a fix while listing domains, on full page reload, it goes back to the root domain
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4769: UI: Save and auto-expand list domain when reloading
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4769:
URL: https://github.com/apache/cloudstack/pull/4769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4769: UI: Save and auto-expand list domain when reloading
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4769:
URL: https://github.com/apache/cloudstack/pull/4769#issuecomment-813305770
@utchoang can you fix the conflict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4769: UI: Save and auto-expand list domain when reloading
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4769:
URL: https://github.com/apache/cloudstack/pull/4769#issuecomment-796583385
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4769: UI: Save and auto-expand list domain when reloading
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4769:
URL: https://github.com/apache/cloudstack/pull/4769#issuecomment-806419282
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4769: UI: Save and auto-expand list domain when reloading
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4769:
URL: https://github.com/apache/cloudstack/pull/4769#issuecomment-813337213
@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4769: UI: Save and auto-expand list domain when reloading
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4769:
URL: https://github.com/apache/cloudstack/pull/4769#issuecomment-806419737
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4769: UI: Save and auto-expand list domain when reloading
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4769:
URL: https://github.com/apache/cloudstack/pull/4769#issuecomment-792570526
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4769 (JID-3857)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4769: UI: Save and auto-expand list domain when reloading
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4769:
URL: https://github.com/apache/cloudstack/pull/4769#issuecomment-806443206
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4769: UI: Save and auto-expand list domain when reloading
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4769:
URL: https://github.com/apache/cloudstack/pull/4769#issuecomment-806445473
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4769 (SL-JID-72)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4769: UI: Save and auto-expand list domain when reloading
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4769:
URL: https://github.com/apache/cloudstack/pull/4769#issuecomment-796582816
@blueorangutan ui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4769: UI: Save and auto-expand list domain when reloading
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4769:
URL: https://github.com/apache/cloudstack/pull/4769#issuecomment-806442584
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4769: UI: Save and auto-expand list domain when reloading
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4769:
URL: https://github.com/apache/cloudstack/pull/4769#issuecomment-792567515
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #4769: UI: Save and auto-expand list domain when reloading
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #4769:
URL: https://github.com/apache/cloudstack/pull/4769#discussion_r590596283
##########
File path: ui/src/components/view/TreeView.vue
##########
@@ -213,6 +215,40 @@ export default {
}
this.reloadTreeData(newData)
+ },
+ treeVerticalData () {
+ if (!this.domainStore.isExpand) {
+ return
+ }
+ if (this.domainStore.expands && this.domainStore.expands.length > 0) {
+ for (let i = 0; i < this.domainStore.expands.length; i++) {
Review comment:
Suggestion:
I think it will be more interesting if we use a `for...of` here, to simplify the code.
```js
for (let expandKey of this.domainStore.expands) {
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4769: UI: Save and auto-expand list domain when reloading
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4769:
URL: https://github.com/apache/cloudstack/pull/4769#issuecomment-813336822
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4769: UI: Save and auto-expand list domain when reloading
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4769:
URL: https://github.com/apache/cloudstack/pull/4769#issuecomment-806439369
UI build: :heavy_multiplication_x:
(SL-JID-68)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4769: UI: Save and auto-expand list domain when reloading
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4769:
URL: https://github.com/apache/cloudstack/pull/4769#issuecomment-813338690
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4769 (SL-JID-89)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4769: UI: Save and auto-expand list domain when reloading
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4769:
URL: https://github.com/apache/cloudstack/pull/4769#issuecomment-792566655
@blueorangutan ui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4769: UI: Save and auto-expand list domain when reloading
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4769:
URL: https://github.com/apache/cloudstack/pull/4769#issuecomment-806435195
@utchoang
```
error in ./src/store/modules/user.js
Module Error (from ./node_modules/thread-loader/dist/cjs.js):
/jenkins/workspace/acs-pr-ui-builder/ui/src/store/modules/user.js
35:3 error 'HEADER_NOTICES' is defined but never used no-unused-vars
90:18 error 'ASYNC_JOB_IDS' is not defined no-undef
275:23 error 'ASYNC_JOB_IDS' is not defined no-undef
290:34 error 'ASYNC_JOB_IDS' is not defined no-undef
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org