You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "llphxd (via GitHub)" <gi...@apache.org> on 2025/02/22 11:17:01 UTC
[PR] [MINOR][DOCS] Fixed the scope of the query option in sql-data-sources-jdbc.md [spark]
llphxd opened a new pull request, #50048:
URL: https://github.com/apache/spark/pull/50048
### What changes were proposed in this pull request?
The documentation shows that the scope of jdbc's option is read/write, but after looking at the source code and testing it, it should actually only be read.
This error has persisted for multiple versions and is still not fixed.
source code:
https://github.com/apache/spark/blob/a661f9f305d96331338938e14b6ea0075f234aee/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala#L287
code snippet:
test snippet:
### Why are the changes needed?
This avoids user confusion about the use of this option and avoids errors in its use
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No testing required, just modifying the document
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Fixed the scope of the query option in sql-data-sources-jdbc.md [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #50048:
URL: https://github.com/apache/spark/pull/50048#issuecomment-2676227781
Please config your GA.
https://github.com/apache/spark/pull/50048/checks?check_run_id=37647515971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51297][DOCS] Fixed the scope of the query option in sql-data-sources-jdbc.md [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #50048:
URL: https://github.com/apache/spark/pull/50048#issuecomment-2677392603
Merged into branch-4.0/master
@llphxd @HyukjinKwon @yaooqinn Thank you all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51297][DOCS] Fixed the scope of the query option in sql-data-sources-jdbc.md [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer closed pull request #50048: [SPARK-51297][DOCS] Fixed the scope of the query option in sql-data-sources-jdbc.md
URL: https://github.com/apache/spark/pull/50048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Fixed the scope of the query option in sql-data-sources-jdbc.md [spark]
Posted by "llphxd (via GitHub)" <gi...@apache.org>.
llphxd commented on PR #50048:
URL: https://github.com/apache/spark/pull/50048#issuecomment-2676389543
> Good catch!. cc @dilipbiswal Because this is a bug, could you create an issue ?
I would love to, but I failed to register jira and have to wait 24 hours. So I'll create the issue later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Fixed the scope of the query option in sql-data-sources-jdbc.md [spark]
Posted by "llphxd (via GitHub)" <gi...@apache.org>.
llphxd commented on PR #50048:
URL: https://github.com/apache/spark/pull/50048#issuecomment-2676361389
> Please config your GA. https://github.com/apache/spark/pull/50048/checks?check_run_id=37647515971
I opened GA, but I don't know how to re-trigger build, can you help me, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Fixed the scope of the query option in sql-data-sources-jdbc.md [spark]
Posted by "llphxd (via GitHub)" <gi...@apache.org>.
llphxd commented on PR #50048:
URL: https://github.com/apache/spark/pull/50048#issuecomment-2676709230
> > I would love to, but I failed to register jira and have to wait 24 hours. So I'll create the issue later.
>
> Please tell me if the issue is ready.
issue is ready.
[https://issues.apache.org/jira/browse/SPARK-51297](url)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Fixed the scope of the query option in sql-data-sources-jdbc.md [spark]
Posted by "llphxd (via GitHub)" <gi...@apache.org>.
llphxd commented on PR #50048:
URL: https://github.com/apache/spark/pull/50048#issuecomment-2676360693
> 好球！cc@dilipbiswal 因为这是一个错误，你能创建一个问题吗？
I would love to, but I failed to register jira and have to wait 24 hours
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Fixed the scope of the query option in sql-data-sources-jdbc.md [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #50048:
URL: https://github.com/apache/spark/pull/50048#issuecomment-2676625435
> I would love to, but I failed to register jira and have to wait 24 hours. So I'll create the issue later.
Please tell me if the issue is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org