You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Robert Munteanu <ro...@apache.org> on 2015/10/16 22:31:30 UTC
Moving tooling/maven out of the main reactor?
Hi,
When releasing the Maven archetypes I was reminded that we build all
the Maven stuff with the main reactor POM.
IMO the tooling part is not part of the Sling product like the bundles
/ tests / launchpads. They participate in building the product, but
they are not needed in the same reactor. Also, we can't consume
SNASPHOT Maven plugins as part of the same reactor. So I would suggest
that we move the tooling/maven out of the main reactor, with the
following changes:
1. Remove all tooling/maven stuff out of the main reactor
2. Create a reactor pom for tooling/maven which builds the plugins
3. Create a reactor pom for tooling/maven/archetypes which builds the
archetypes
4. Include tooling/maven/archetypes as a module of tooling/maven
5. Create a separate sling-tooling-trunk-1.7 build on Jekins
Advantages:
1. Slightly faster builds ( have not really measured )
2. The main reactor does not break when the tooling/maven one breaks (
like I did earlier :-) )
Thoughts?
Robert
Re: Moving tooling/maven out of the main reactor?
Posted by Julian Sedding <js...@gmail.com>.
Hi Robert
Your suggestions sound sensible and shouldn't hurt in any way.
In addition to your points above, we could consider, purely for
convenience, adding a profile to the main reactor pom that builds
tooling/maven.
Regards
Julian
On Fri, Oct 16, 2015 at 10:31 PM, Robert Munteanu <ro...@apache.org> wrote:
> Hi,
>
> When releasing the Maven archetypes I was reminded that we build all
> the Maven stuff with the main reactor POM.
>
> IMO the tooling part is not part of the Sling product like the bundles
> / tests / launchpads. They participate in building the product, but
> they are not needed in the same reactor. Also, we can't consume
> SNASPHOT Maven plugins as part of the same reactor. So I would suggest
> that we move the tooling/maven out of the main reactor, with the
> following changes:
>
> 1. Remove all tooling/maven stuff out of the main reactor
> 2. Create a reactor pom for tooling/maven which builds the plugins
> 3. Create a reactor pom for tooling/maven/archetypes which builds the
> archetypes
> 4. Include tooling/maven/archetypes as a module of tooling/maven
> 5. Create a separate sling-tooling-trunk-1.7 build on Jekins
>
> Advantages:
>
> 1. Slightly faster builds ( have not really measured )
> 2. The main reactor does not break when the tooling/maven one breaks (
> like I did earlier :-) )
>
> Thoughts?
>
> Robert
Re: Moving tooling/maven out of the main reactor?
Posted by Carsten Ziegeler <cz...@apache.org>.
Am 16.10.15 um 22:31 schrieb Robert Munteanu:
> Hi,
>
> When releasing the Maven archetypes I was reminded that we build all
> the Maven stuff with the main reactor POM.
>
> IMO the tooling part is not part of the Sling product like the bundles
> / tests / launchpads. They participate in building the product, but
> they are not needed in the same reactor. Also, we can't consume
> SNASPHOT Maven plugins as part of the same reactor. So I would suggest
> that we move the tooling/maven out of the main reactor, with the
> following changes:
>
> 1. Remove all tooling/maven stuff out of the main reactor
> 2. Create a reactor pom for tooling/maven which builds the plugins
> 3. Create a reactor pom for tooling/maven/archetypes which builds the
> archetypes
> 4. Include tooling/maven/archetypes as a module of tooling/maven
> 5. Create a separate sling-tooling-trunk-1.7 build on Jekins
>
> Advantages:
>
> 1. Slightly faster builds ( have not really measured )
> 2. The main reactor does not break when the tooling/maven one breaks (
> like I did earlier :-) )
>
> Thoughts?
>
Sounds good to me
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
Re: Moving tooling/maven out of the main reactor?
Posted by Robert Munteanu <ro...@apache.org>.
On Mon, 2015-10-19 at 11:11 +0200, Bertrand Delacretaz wrote:
> On Fri, Oct 16, 2015 at 10:31 PM, Robert Munteanu <rombert@apache.org
> > wrote:
> > ...So I would suggest
> > that we move the tooling/maven out of the main reactor, with the
> > following changes..
>
> +1, sounds good!
> -Bertrand
Thanks to all for the feedback. I'll make the changes and make a note
of them in SLING-920.
Robert
Re: Moving tooling/maven out of the main reactor?
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Fri, Oct 16, 2015 at 10:31 PM, Robert Munteanu <ro...@apache.org> wrote:
> ...So I would suggest
> that we move the tooling/maven out of the main reactor, with the
> following changes..
+1, sounds good!
-Bertrand