You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by rh...@apache.org on 2010/03/25 11:22:28 UTC

svn commit: r927328 - /subversion/trunk/subversion/libsvn_subr/atomic.c

Author: rhuijben
Date: Thu Mar 25 10:22:28 2010
New Revision: 927328

URL: http://svn.apache.org/viewvc?rev=927328&view=rev
Log:
* subversion/libsvn_subr/atomic.c
  (svn_atomic__init_once): Following up on r927323, add comment.

Suggested by: julianf

Modified:
    subversion/trunk/subversion/libsvn_subr/atomic.c

Modified: subversion/trunk/subversion/libsvn_subr/atomic.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/atomic.c?rev=927328&r1=927327&r2=927328&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/atomic.c (original)
+++ subversion/trunk/subversion/libsvn_subr/atomic.c Thu Mar 25 10:22:28 2010
@@ -33,6 +33,10 @@ svn_error_t*
 svn_atomic__init_once(volatile svn_atomic_t *global_status,
                       svn_error_t *(*init_func)(apr_pool_t*), apr_pool_t* pool)
 {
+  /* !! Don't use localizable strings in this function, because these
+     !! might cause deadlocks. This function can be used to initialize
+     !! libraries that are used for generating error messages. */
+
   /* We have to call init_func exactly once.  Because APR
      doesn't have statically-initialized mutexes, we implement a poor
      man's spinlock using svn_atomic_cas. */