You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/04/24 03:24:49 UTC

[GitHub] [maven-checkstyle-plugin] JLLeitschuh commented on a change in pull request #13: MCHECKSTYLE-366 Upgrade checkstyle to a more recent version

JLLeitschuh commented on a change in pull request #13: MCHECKSTYLE-366 Upgrade checkstyle to a more recent version
URL: https://github.com/apache/maven-checkstyle-plugin/pull/13#discussion_r277943516
 
 

 ##########
 File path: src/it/MCHECKSTYLE-137/checkstyle.xml
 ##########
 @@ -20,8 +20,6 @@ under the License.
 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.2//EN" "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
 
 Review comment:
   @eolivelli The security issue is in the parser that is used to parse this file. It leaves any code that parses this file vulnerable to XXE via a MITM.
   It doesn't matter that it's a "test resource", it still leaves the build vulnerable to this attack vector.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services