You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/10/13 14:19:37 UTC

[GitHub] [commons-codec] jamesgiu opened a new pull request #64: Add form feed and vertical tab whitespace to isWhiteSpace()

jamesgiu opened a new pull request #64:
URL: https://github.com/apache/commons-codec/pull/64


   Ran into an issue with these characters not being detected and having false positive isBase64() detection as a result - would be good to get them counted as whitespace.
   
   Ref. C/C++ `isspace()` function considers these characters as whitespace.
   http://www.cplusplus.com/reference/cctype/isspace/
   https://www.oreilly.com/library/view/c-in-a/0596006977/re129.html
   
   Cheers!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-codec] jamesgiu commented on pull request #64: Add form feed and vertical tab whitespace to isWhiteSpace()

Posted by GitBox <gi...@apache.org>.
jamesgiu commented on pull request #64:
URL: https://github.com/apache/commons-codec/pull/64#issuecomment-779500164


   Hi all, any chance this will be looked at? Cheers :) 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-codec] garydgregory commented on pull request #64: Add form feed and vertical tab whitespace to isWhiteSpace()

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #64:
URL: https://github.com/apache/commons-codec/pull/64#issuecomment-779527408


   This method or PR is not great because we are defining our own whitespace instead of reusing Charater.isWhitespace or Charater.isSpaceChar. 
   
   Shouldn't we be using Charater.isSomething?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-codec] coveralls commented on pull request #64: Add form feed and vertical tab whitespace to isWhiteSpace()

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #64:
URL: https://github.com/apache/commons-codec/pull/64#issuecomment-707789648


   
   [![Coverage Status](https://coveralls.io/builds/34140078/badge)](https://coveralls.io/builds/34140078)
   
   Coverage remained the same at 94.308% when pulling **90248547061e7708c6e2e2807e60feacfcb12680 on jamesgiu:VT-and-FF-in-BNCodec** into **475910a521bd23dbba26091be505ad2a71d3e901 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-codec] garydgregory edited a comment on pull request #64: Add form feed and vertical tab whitespace to isWhiteSpace()

Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #64:
URL: https://github.com/apache/commons-codec/pull/64#issuecomment-1040311595


   Ping. Also, how does this square with the RFCs for Base64, Base32, and Base16 (all the subclasses we implement)? IOW, what C/C++ does is completely irrelevant, it's the RFCs that matter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-codec] garydgregory edited a comment on pull request #64: Add form feed and vertical tab whitespace to isWhiteSpace()

Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #64:
URL: https://github.com/apache/commons-codec/pull/64#issuecomment-1040311595


   Ping. Also, how does this square with the RFCs for Base64, Base32, and Base16?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-codec] garydgregory edited a comment on pull request #64: Add form feed and vertical tab whitespace to isWhiteSpace()

Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #64:
URL: https://github.com/apache/commons-codec/pull/64#issuecomment-1040311595






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-codec] garydgregory edited a comment on pull request #64: Add form feed and vertical tab whitespace to isWhiteSpace()

Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #64:
URL: https://github.com/apache/commons-codec/pull/64#issuecomment-1040311595


   Ping. Also, how does this square with the RFCs for Base64, Base32, and Base16 -- all the subclasses we implement? IOW, What C/C++ does is completely irrelevant, it's the RFCs that matter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-codec] garydgregory commented on pull request #64: Add form feed and vertical tab whitespace to isWhiteSpace()

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #64:
URL: https://github.com/apache/commons-codec/pull/64#issuecomment-1040311595


   Ping. Also how does this square with the RFCs for Base64, Base32, and Base16?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-codec] garydgregory commented on pull request #64: Add form feed and vertical tab whitespace to isWhiteSpace()

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #64:
URL: https://github.com/apache/commons-codec/pull/64#issuecomment-1040311595


   Ping. Also how does this square with the RFCs for Base64, Base32, and Base16?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org