You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/03/19 06:38:40 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #3146: [Bug]
Get NPE when executing show alter table statement
morningman opened a new pull request #3146: [Bug] Get NPE when executing show alter table statement
URL: https://github.com/apache/incubator-doris/pull/3146
This PR #3130 will clear some structures of alter job after job is done.
But these structures may be used in show alter table statement. So
that they can not be cleared.
In this CL, I removed the `clear()` method of alter job. And add a new edit log
`REMOVE_ALTER_JOB` to notify non-master FE that the expired alter job
has been removed.
Also add a new proc node for schema change job, for viewing the unfinished task of
a schema change job.
ISSUE: #3145
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on a change in pull request
#3146: [Bug] Get NPE when executing show alter table statement
Posted by GitBox <gi...@apache.org>.
WingsGo commented on a change in pull request #3146: [Bug] Get NPE when executing show alter table statement
URL: https://github.com/apache/incubator-doris/pull/3146#discussion_r394827417
##########
File path: fe/src/main/java/org/apache/doris/persist/RemoveAlterJobOperationLog.java
##########
@@ -0,0 +1,64 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.persist;
+
+import org.apache.doris.alter.AlterJobV2;
+import org.apache.doris.common.io.Text;
+import org.apache.doris.common.io.Writable;
+import org.apache.doris.persist.gson.GsonUtils;
+
+import com.google.gson.annotations.SerializedName;
+
+import java.io.DataInput;
+import java.io.DataOutput;
+import java.io.IOException;
+
+
+// edit log from removing alter job v2
+public class RemoveAlterJobOperationLog implements Writable {
Review comment:
maybe `RemoveAlterJobV2OperationLog` is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request
#3146: [Bug] Get NPE when executing show alter table statement
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3146: [Bug] Get NPE when executing show alter table statement
URL: https://github.com/apache/incubator-doris/pull/3146#discussion_r395003432
##########
File path: fe/src/main/java/org/apache/doris/persist/RemoveAlterJobOperationLog.java
##########
@@ -0,0 +1,64 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.persist;
+
+import org.apache.doris.alter.AlterJobV2;
+import org.apache.doris.common.io.Text;
+import org.apache.doris.common.io.Writable;
+import org.apache.doris.persist.gson.GsonUtils;
+
+import com.google.gson.annotations.SerializedName;
+
+import java.io.DataInput;
+import java.io.DataOutput;
+import java.io.IOException;
+
+
+// edit log from removing alter job v2
+public class RemoveAlterJobOperationLog implements Writable {
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request
#3146: [Bug] Get NPE when executing show alter table statement
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3146: [Bug] Get NPE when executing show alter table statement
URL: https://github.com/apache/incubator-doris/pull/3146#discussion_r395003350
##########
File path: fe/src/main/java/org/apache/doris/persist/EditLog.java
##########
@@ -1257,4 +1271,8 @@ public void logReplaceTempPartition(ReplacePartitionOperationLog info) {
public void logSetReplicaStatus(SetReplicaStatusOperationLog log) {
logEdit(OperationType.OP_SET_REPLICA_STATUS, log);
}
+
+ public void logRemoveExpiredAlterJob(RemoveAlterJobOperationLog log) {
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on a change in pull request
#3146: [Bug] Get NPE when executing show alter table statement
Posted by GitBox <gi...@apache.org>.
WingsGo commented on a change in pull request #3146: [Bug] Get NPE when executing show alter table statement
URL: https://github.com/apache/incubator-doris/pull/3146#discussion_r394826991
##########
File path: fe/src/main/java/org/apache/doris/persist/EditLog.java
##########
@@ -1257,4 +1271,8 @@ public void logReplaceTempPartition(ReplacePartitionOperationLog info) {
public void logSetReplicaStatus(SetReplicaStatusOperationLog log) {
logEdit(OperationType.OP_SET_REPLICA_STATUS, log);
}
+
+ public void logRemoveExpiredAlterJob(RemoveAlterJobOperationLog log) {
Review comment:
public void logRemoveExpireAlterJobV2(RemoveAlterJobV2OperationLog log) to avoid mislead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chaoyli merged pull request #3146: [Bug] Get NPE
when executing show alter table statement
Posted by GitBox <gi...@apache.org>.
chaoyli merged pull request #3146: [Bug] Get NPE when executing show alter table statement
URL: https://github.com/apache/incubator-doris/pull/3146
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org