You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2013/10/14 00:30:48 UTC

Review Request 14622: Authentication fix in task reconciliation test

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14622/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Bugs: MESOS-734
    https://issues.apache.org/jira/browse/MESOS-734


Repository: mesos-git


Description
-------

New task reconciliation test breaks test suite due to missing authentication:

[ RUN      ] MasterTest.ReconcileTaskTest

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: error(0x7fff59590318, @0x7f8890c3be10 "Framework at scheduler(13)@127.0.0.1:64373 is not authenticated.")
Stack trace:
tests/master_tests.cpp:1066: Failure
Failed to wait 10secs for status


Diffs
-----

  src/tests/master_tests.cpp c325c10 

Diff: https://reviews.apache.org/r/14622/diff/


Testing
-------

$ make check
...
[ RUN      ] MasterTest.ReconcileTaskTest
[       OK ] MasterTest.ReconcileTaskTest (37 ms)
...


Thanks,

Niklas Nielsen


Re: Review Request 14622: Authentication fix in task reconciliation test

Posted by Benjamin Hindman <be...@berkeley.edu>.

> On Oct. 13, 2013, 10:47 p.m., Benjamin Hindman wrote:
> > Ship It!

Thanks Niklas, you can mark this as submitted and resolve the JIRA issue.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14622/#review26967
-----------------------------------------------------------


On Oct. 13, 2013, 10:30 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14622/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2013, 10:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-734
>     https://issues.apache.org/jira/browse/MESOS-734
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> New task reconciliation test breaks test suite due to missing authentication:
> 
> [ RUN      ] MasterTest.ReconcileTaskTest
> 
> GMOCK WARNING:
> Uninteresting mock function call - returning directly.
>     Function call: error(0x7fff59590318, @0x7f8890c3be10 "Framework at scheduler(13)@127.0.0.1:64373 is not authenticated.")
> Stack trace:
> tests/master_tests.cpp:1066: Failure
> Failed to wait 10secs for status
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp c325c10 
> 
> Diff: https://reviews.apache.org/r/14622/diff/
> 
> 
> Testing
> -------
> 
> $ make check
> ...
> [ RUN      ] MasterTest.ReconcileTaskTest
> [       OK ] MasterTest.ReconcileTaskTest (37 ms)
> ...
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Re: Review Request 14622: Authentication fix in task reconciliation test

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14622/#review26967
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Oct. 13, 2013, 10:30 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14622/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2013, 10:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-734
>     https://issues.apache.org/jira/browse/MESOS-734
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> New task reconciliation test breaks test suite due to missing authentication:
> 
> [ RUN      ] MasterTest.ReconcileTaskTest
> 
> GMOCK WARNING:
> Uninteresting mock function call - returning directly.
>     Function call: error(0x7fff59590318, @0x7f8890c3be10 "Framework at scheduler(13)@127.0.0.1:64373 is not authenticated.")
> Stack trace:
> tests/master_tests.cpp:1066: Failure
> Failed to wait 10secs for status
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp c325c10 
> 
> Diff: https://reviews.apache.org/r/14622/diff/
> 
> 
> Testing
> -------
> 
> $ make check
> ...
> [ RUN      ] MasterTest.ReconcileTaskTest
> [       OK ] MasterTest.ReconcileTaskTest (37 ms)
> ...
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>