You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "Josh Elser (JIRA)" <ji...@apache.org> on 2014/02/01 04:30:08 UTC

[jira] [Commented] (ACCUMULO-2292) Fix findbugs/pmd errors for 1.5.1

    [ https://issues.apache.org/jira/browse/ACCUMULO-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888433#comment-13888433 ] 

Josh Elser commented on ACCUMULO-2292:
--------------------------------------

I updated the 2292-findbugs branch again:

We started with 1408 errors from findbugs. With the changes I made, we got down to 849 errors. Combine that with the ignored thrift-generated classes (ACCUMULO-2296), we get down to 332.

I'll hold off for a little while if people want to review these changes. The vast majority that I fixed were encoding issues. The rest were primarily split between unnecessary String, Long, or Integer creation, and using entrySet instead of keySet. 

> Fix findbugs/pmd errors for 1.5.1
> ---------------------------------
>
>                 Key: ACCUMULO-2292
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2292
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 1.5.1
>
>
> Analyze findbugs/pmd report and fix errors.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)