You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/07 10:48:00 UTC
[jira] [Commented] (NIFI-5278) ExecuteSparkInteractive processor
fails on code containing a quote
[ https://issues.apache.org/jira/browse/NIFI-5278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504521#comment-16504521 ]
ASF GitHub Bot commented on NIFI-5278:
--------------------------------------
GitHub user peter-toth opened a pull request:
https://github.com/apache/nifi/pull/2768
NIFI-5278: fixes JSON escaping of code parameter in Execute Spark Interactive processor
Change-Id: I2cb0e6c658d4a0f2aad9c4aab9201a3334ee54df
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/peter-toth/nifi NIFI-5278
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2768.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2768
----
commit f54792cd58e69bc43323ef9a063cce4c5c956e61
Author: Peter Toth <pt...@...>
Date: 2018-06-07T10:13:21Z
NIFI-5278: fixes JSON escaping of code
Change-Id: I2cb0e6c658d4a0f2aad9c4aab9201a3334ee54df
----
> ExecuteSparkInteractive processor fails on code containing a quote
> ------------------------------------------------------------------
>
> Key: NIFI-5278
> URL: https://issues.apache.org/jira/browse/NIFI-5278
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.6.0
> Reporter: Peter Toth
> Priority: Major
>
> ExecuteSparkInteractive usesĀ org.apache.commons.lang.StringEscapeUtils.escapeJavaScript() which results quotes to be escaped as \'. This breaks JSON payload of the Livy REST API.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)