You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2014/12/26 15:17:54 UTC
svn commit: r1647982 - in
/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff:
CFFExpertSubsetCharset.java CFFISOAdobeCharset.java CFFOperator.java
CFFStandardString.java CFFType1Font.java Type1FontUtil.java
Author: tilman
Date: Fri Dec 26 14:17:54 2014
New Revision: 1647982
URL: http://svn.apache.org/r1647982
Log:
PDFBOX-2576: class which has only private constructors should be declared as final
Modified:
pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFExpertSubsetCharset.java
pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFISOAdobeCharset.java
pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFOperator.java
pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFStandardString.java
pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFType1Font.java
pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/Type1FontUtil.java
Modified: pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFExpertSubsetCharset.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFExpertSubsetCharset.java?rev=1647982&r1=1647981&r2=1647982&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFExpertSubsetCharset.java (original)
+++ pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFExpertSubsetCharset.java Fri Dec 26 14:17:54 2014
@@ -23,7 +23,7 @@ package org.apache.fontbox.cff;
* @author Villu Ruusmann
* @version $Revision$
*/
-public class CFFExpertSubsetCharset extends CFFCharset
+public final class CFFExpertSubsetCharset extends CFFCharset
{
private CFFExpertSubsetCharset()
Modified: pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFISOAdobeCharset.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFISOAdobeCharset.java?rev=1647982&r1=1647981&r2=1647982&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFISOAdobeCharset.java (original)
+++ pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFISOAdobeCharset.java Fri Dec 26 14:17:54 2014
@@ -23,7 +23,7 @@ package org.apache.fontbox.cff;
* @author Villu Ruusmann
* @version $Revision$
*/
-public class CFFISOAdobeCharset extends CFFCharset
+public final class CFFISOAdobeCharset extends CFFCharset
{
private CFFISOAdobeCharset()
Modified: pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFOperator.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFOperator.java?rev=1647982&r1=1647981&r2=1647982&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFOperator.java (original)
+++ pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFOperator.java Fri Dec 26 14:17:54 2014
@@ -68,6 +68,7 @@ public class CFFOperator
/**
* {@inheritDoc}
*/
+ @Override
public String toString()
{
return getName();
@@ -76,6 +77,7 @@ public class CFFOperator
/**
* {@inheritDoc}
*/
+ @Override
public int hashCode()
{
return getKey().hashCode();
@@ -84,6 +86,7 @@ public class CFFOperator
/**
* {@inheritDoc}
*/
+ @Override
public boolean equals(Object object)
{
if (object instanceof CFFOperator)
@@ -170,6 +173,7 @@ public class CFFOperator
/**
* {@inheritDoc}
*/
+ @Override
public String toString()
{
return Arrays.toString(getValue());
@@ -178,6 +182,7 @@ public class CFFOperator
/**
* {@inheritDoc}
*/
+ @Override
public int hashCode()
{
return Arrays.hashCode(getValue());
@@ -186,6 +191,7 @@ public class CFFOperator
/**
* {@inheritDoc}
*/
+ @Override
public boolean equals(Object object)
{
if (object instanceof Key)
Modified: pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFStandardString.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFStandardString.java?rev=1647982&r1=1647981&r2=1647982&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFStandardString.java (original)
+++ pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFStandardString.java Fri Dec 26 14:17:54 2014
@@ -21,7 +21,7 @@ package org.apache.fontbox.cff;
* @author Villu Ruusmann
* @version $Revision: 1.0 $
*/
-public class CFFStandardString
+public final class CFFStandardString
{
private CFFStandardString()
Modified: pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFType1Font.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFType1Font.java?rev=1647982&r1=1647981&r2=1647982&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFType1Font.java (original)
+++ pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CFFType1Font.java Fri Dec 26 14:17:54 2014
@@ -61,6 +61,7 @@ public class CFFType1Font extends CFFFon
return fontName;
}
+ @Override
public GeneralPath getPath(String name) throws IOException
{
return getType1CharString(name).getPath();
@@ -164,6 +165,7 @@ public class CFFType1Font extends CFFFon
*
* @return the encoding
*/
+ @Override
public CFFEncoding getEncoding()
{
return encoding;
Modified: pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/Type1FontUtil.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/Type1FontUtil.java?rev=1647982&r1=1647981&r2=1647982&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/Type1FontUtil.java (original)
+++ pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/Type1FontUtil.java Fri Dec 26 14:17:54 2014
@@ -22,7 +22,7 @@ package org.apache.fontbox.cff;
* @author Villu Ruusmann
* @version $Revision$
*/
-public class Type1FontUtil
+public final class Type1FontUtil
{
private Type1FontUtil()