[GitHub] [incubator-zipkin-website] jcchavezs commented on issue #5: fix: reenables the zipkin-api filter.

[GitBox <gi...@apache.org>]

jcchavezs commented on issue #5: fix: reenables the zipkin-api filter.
URL: https://github.com/apache/incubator-zipkin-website/pull/5#issuecomment-487140150
 
 
   Maybe it is easier to use dependabot? CC @adrianfcole
   
   https://twitter.com/adrianfcole/status/1121684927236300800
   
   fre. 26. apr. 2019, 19:27 skrev Zoltán Nagy <no...@github.com>:
   
   > Cool stuff! Since we're not directing people to zipkin.apache.org yet, I
   > think you should be fine just merging this and iterating on the Jenkinsfile
   > on master.
   >
   > One thing to watch out for will be that we'll want to trigger a build for
   > website when there's a change on api, to make sure it picks up the new
   > Swagger defs. Or we could go about it the other way, and extend the build
   > process of zipkin-api so that it directly commits into the asf-site
   > branch of the website repo.
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-zipkin-website/pull/5#issuecomment-487136411>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAXOYAQS4GAMJT4BB53VTCTPSM3OPANCNFSM4HIUUUFQ>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Re: [GitHub] [incubator-zipkin-website] jcchavezs commented on issue #5: fix: reenables the zipkin-api filter.

[Adrian Cole <ad...@gmail.com>]

since zipkin-api is updated infrequently some automation could help. it
doesnt necessarily need to use a bot as things like triggering downstream
stuff can also be done in Jenkins flows and I dont know why we would want
to not update our website if we updated our api (dependabot and friends are
effectively a manual verification step implemented as a PR bot.. however
this type of work has historically been done by normal automation I think)


cc @shakuzen


On Sat, Apr 27, 2019, 1:38 AM GitBox <gi...@apache.org> wrote:

> jcchavezs commented on issue #5: fix: reenables the zipkin-api filter.
> URL:
> https://github.com/apache/incubator-zipkin-website/pull/5#issuecomment-487140150
>
>
>    Maybe it is easier to use dependabot? CC @adrianfcole
>
>    https://twitter.com/adrianfcole/status/1121684927236300800
>
>    fre. 26. apr. 2019, 19:27 skrev Zoltán Nagy <no...@github.com>:
>
>    > Cool stuff! Since we're not directing people to zipkin.apache.org
> yet, I
>    > think you should be fine just merging this and iterating on the
> Jenkinsfile
>    > on master.
>    >
>    > One thing to watch out for will be that we'll want to trigger a build
> for
>    > website when there's a change on api, to make sure it picks up the new
>    > Swagger defs. Or we could go about it the other way, and extend the
> build
>    > process of zipkin-api so that it directly commits into the asf-site
>    > branch of the website repo.
>    >
>    > —
>    > You are receiving this because you authored the thread.
>    > Reply to this email directly, view it on GitHub
>    > <
> https://github.com/apache/incubator-zipkin-website/pull/5#issuecomment-487136411
> >,
>    > or mute the thread
>    > <
> https://github.com/notifications/unsubscribe-auth/AAXOYAQS4GAMJT4BB53VTCTPSM3OPANCNFSM4HIUUUFQ
> >
>    > .
>    >
>
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> With regards,
> Apache Git Services
>