You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "markusmueller (via GitHub)" <gi...@apache.org> on 2023/12/26 12:51:03 UTC
[PR] Bugfix subattribute duplication in chema generation [directory-scimple]
markusmueller opened a new pull request, #480:
URL: https://github.com/apache/directory-scimple/pull/480
Schema generation of complex type attributes was leading to duplicated subattributes. This can be easily illustrated by taking a closer look at the schemas returned by one of the sample servers (```GET http://localhost:8080/v2/Schemas```). The ```meta``` attribute of the ScimUser schema for example has all its subattributes duplicated.
This PR is adding a test reproducing the bug and a fix in the schema generation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] Bugfix subattribute duplication in schema generation [directory-scimple]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on PR #480:
URL: https://github.com/apache/directory-scimple/pull/480#issuecomment-1869770055
Thanks @markusmueller!
We will get this merged in after the holidays!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] Bugfix subattribute duplication in schema generation [directory-scimple]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers merged PR #480:
URL: https://github.com/apache/directory-scimple/pull/480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] Bugfix subattribute duplication in schema generation [directory-scimple]
Posted by "markusmueller (via GitHub)" <gi...@apache.org>.
markusmueller commented on PR #480:
URL: https://github.com/apache/directory-scimple/pull/480#issuecomment-1874570811
@bdemers I have submitted my CLA to``secretary@apache.org`` just now. Looking forward to a first release on maven central!
Also, I couldn't find any contribution guidelines for the project, are there any?
While implementing a server based on the project I was adding a couple of workarounds for cases which might instead better be handled by the library, for example:
* Making schema generation honor/aware of ServerConfig (i.e. versioning disabled, ```meta.version``` removed from schema/responses)
* Handling of X-Forwarded-* headers behind reverse proxy (schema location, http location headers)
I was mostly working JaxRS filters and sub-classing to work around issues, but happy to sketch some feature proposals in GitHub issues first or please point to contribution guidelines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] Bugfix subattribute duplication in schema generation [directory-scimple]
Posted by "markusmueller (via GitHub)" <gi...@apache.org>.
markusmueller commented on PR #480:
URL: https://github.com/apache/directory-scimple/pull/480#issuecomment-1880441282
@bdemers fyi, I have received a timeout message from the mailer daemon for my CLA mail to the secretary from last week (connect to whimsy-vm6.apache.org[52.6.211.55]:25: Connection timed out). Just sent it again, let' see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] Bugfix subattribute duplication in schema generation [directory-scimple]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on PR #480:
URL: https://github.com/apache/directory-scimple/pull/480#issuecomment-1874647547
@markusmueller Awesome!
Contributing is still a little informal, just keep doing what you are doing!
We do have a mailing list: `scimple@directory.apache.org`
https://directory.apache.org/mailing-lists-and-irc.html
I love your ideas! please create a few issues!
Related (though less interesting then the bean validation!) the `ScimAttribute` annotations could be used for a few other things too, OpenAPI spec generation, remove the JAXB annotation duplication.
> **NOTE:** I'm not sure if the current OpenAPI annotations have much value, as SCIM is a fixed spec, so it doesn't really need to be generated by SCIMple 🤷. I'm also not sure if fixing the JAXB overlap is practical. I just wanted to get the conversation going 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] Bugfix subattribute duplication in schema generation [directory-scimple]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on PR #480:
URL: https://github.com/apache/directory-scimple/pull/480#issuecomment-1874219914
@markusmueller Thanks again! These are great fixes!
Can you sign a Apache CLA (if you haven't already)
https://www.apache.org/licenses/contributor-agreements.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org