[GitHub] jlahoda commented on a change in pull request #997: Simplifying semantic highlighter.

[GitBox <gi...@apache.org>]

jlahoda commented on a change in pull request #997: Simplifying semantic highlighter.
URL: https://github.com/apache/incubator-netbeans/pull/997#discussion_r234405414
 
 

 ##########
 File path: java/java.editor.base/src/org/netbeans/modules/java/editor/base/semantic/SemanticHighlighterBase.java
 ##########
 @@ -897,38 +835,33 @@ public Void visitRequires(RequiresTree tree, EnumSet<UseTypes> d) {
                     }
                 }
             }
-            return super.visitRequires(tree, d);
+            return super.visitRequires(tree, p);
         }
 
         @Override
-        public Void visitUses(UsesTree tree, EnumSet<UseTypes> d) {
+        public Void visitUses(UsesTree tree, Void p) {
             tl.moveToOffset(sourcePositions.getStartPosition(info.getCompilationUnit(), tree));
             Token t = firstIdentifierToken("uses"); //NOI18N
             if (t != null) {
                 contextKeywords.add(t);
             }
-            return super.visitUses(tree, d);
+            return super.visitUses(tree, p);
         }
                 
-        private long startOf(List<? extends Tree> trees) {
-            if (trees.isEmpty()) return -1;
-            return sourcePositions.getStartPosition(info.getCompilationUnit(), trees.get(0));
-        }
-
         private void handleMethodTypeArguments(TreePath method, List<? extends Tree> tArgs) {
             //the type arguments are before the last identifier in the select, so we should return there:
             //not very efficient, though:
             tl.moveBefore(tArgs);
             
-            for (Tree expr : tArgs) {
-                if (expr instanceof IdentifierTree) {
-                    handlePossibleIdentifier(new TreePath(method, expr), EnumSet.of(UseTypes.CLASS_USE));
-                }
-            }
+//            for (Tree expr : tArgs) {
 
 Review comment:
   Leftover, removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists