You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/07 23:19:12 UTC
[GitHub] [pulsar-client-python] merlimat opened a new pull request, #9: Add CI job to build and run Python tests
merlimat opened a new pull request, #9:
URL: https://github.com/apache/pulsar-client-python/pull/9
Fixed build and added Github actions to validate PR with unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-python] BewareMyPower merged pull request #9: Add CI job to build and run Python tests
Posted by GitBox <gi...@apache.org>.
BewareMyPower merged PR #9:
URL: https://github.com/apache/pulsar-client-python/pull/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-python] BewareMyPower commented on a diff in pull request #9: Add CI job to build and run Python tests
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on code in PR #9:
URL: https://github.com/apache/pulsar-client-python/pull/9#discussion_r990575612
##########
build-support/install-cpp-client.sh:
##########
@@ -0,0 +1,36 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+set -e -x
+
+ROOT_DIR=$(git rev-parse --show-toplevel)
+
+cd $ROOT_DIR
+
+CPP_CLIENT_VERSION=$(cat pulsar-client-cpp-version.txt | xargs)
+
+# Fetch the client binaries
+## TODO: Fetch from official release once it's available
+pushd /tmp
+ curl -L -O https://github.com/merlimat/pulsar-client-cpp/releases/download/${CPP_CLIENT_VERSION}/apache-pulsar-client.deb
+ curl -L -O https://github.com/merlimat/pulsar-client-cpp/releases/download/${CPP_CLIENT_VERSION}/apache-pulsar-client-dev.deb
+popd
+
+sudo apt install /tmp/apache-pulsar-client.deb /tmp/apache-pulsar-client-dev.deb
Review Comment:
Could you remove the `sudo` here and add the `sudo` in the `ci-pr-validation.yaml`? It could be better for those want to simulate the workflow in local env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-python] BewareMyPower commented on a diff in pull request #9: Add CI job to build and run Python tests
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on code in PR #9:
URL: https://github.com/apache/pulsar-client-python/pull/9#discussion_r990582194
##########
build-support/install-cpp-client.sh:
##########
@@ -0,0 +1,36 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+set -e -x
+
+ROOT_DIR=$(git rev-parse --show-toplevel)
+
+cd $ROOT_DIR
+
+CPP_CLIENT_VERSION=$(cat pulsar-client-cpp-version.txt | xargs)
+
+# Fetch the client binaries
+## TODO: Fetch from official release once it's available
+pushd /tmp
+ curl -L -O https://github.com/merlimat/pulsar-client-cpp/releases/download/${CPP_CLIENT_VERSION}/apache-pulsar-client.deb
+ curl -L -O https://github.com/merlimat/pulsar-client-cpp/releases/download/${CPP_CLIENT_VERSION}/apache-pulsar-client-dev.deb
+popd
+
+sudo apt install /tmp/apache-pulsar-client.deb /tmp/apache-pulsar-client-dev.deb
Review Comment:
It's not an issue, ignore it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org