You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/20 03:31:32 UTC
[GitHub] [apisix-ingress-controller] tao12345666333 opened a new issue, #1547: chore: improve make update-all
tao12345666333 opened a new issue, #1547:
URL: https://github.com/apache/apisix-ingress-controller/issues/1547
`make update-all` should not modify the CHANGELOG file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 closed issue #1547: chore: improve make update-all
Posted by GitBox <gi...@apache.org>.
tao12345666333 closed issue #1547: chore: improve make update-all
URL: https://github.com/apache/apisix-ingress-controller/issues/1547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] Gallardot commented on issue #1547: chore: improve make update-all
Posted by GitBox <gi...@apache.org>.
Gallardot commented on issue #1547:
URL: https://github.com/apache/apisix-ingress-controller/issues/1547#issuecomment-1396511035
Hi @tao12345666333
I think this issue has been fixed in this PR. [#1500](https://github.com/apache/apisix-ingress-controller/pull/1500/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R242)
But I found another issue, that is, `make update-all` will execute `update-gofmt` to fix the imports issue, but the current github CI doesn't check this. So I create a PR to fix it. #1606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1547: chore: improve make update-all
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #1547:
URL: https://github.com/apache/apisix-ingress-controller/issues/1547#issuecomment-1396942090
Great! I will close this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org