You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/09 07:23:40 UTC
[GitHub] [cloudstack-primate] utchoang opened a new pull request #99: [WIP]
- Recurring Volume Snapshot Custom Action Form
utchoang opened a new pull request #99: [WIP] - Recurring Volume Snapshot Custom Action Form
URL: https://github.com/apache/cloudstack-primate/pull/99
@rhtyd cc @svenvogel
This is the design of the Recurring Volume Snapshot Action. Please let me know your comments.
* Schedule:
* Scheduled snapshots:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #99: [WIP] -
Recurring Volume Snapshot Custom Action Form
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #99: [WIP] - Recurring Volume Snapshot Custom Action Form
URL: https://github.com/apache/cloudstack-primate/pull/99#issuecomment-574046988
@utchoang reviewed, LGTM except for this few issues:
1. Please always checkout new work/branch from origin/master, otherwise the PRs will have commits from other PRs/branches and will cause difficulties in reviewing them. I've fixed it manually for at least two PRs for now.
2. When I open the recurring action form the first time, I'm unable to list the timezones:
I've moved the timezone file/folder under utils and changed the import paths. It's also okay if instead of resolve/importing the json, you want to consume it as a static object/map.
3. While you're at it, can you also fix the createSnapshot form which takes in tags, which is not supported out of the box:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #99: [WIP] -
Recurring Volume Snapshot Custom Action Form
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #99: [WIP] - Recurring Volume Snapshot Custom Action Form
URL: https://github.com/apache/cloudstack-primate/pull/99#issuecomment-572456418
Great, thanks @utchoang I'll review and get back to you by end of tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #99: [WIP] -
Recurring Volume Snapshot Custom Action Form
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #99: [WIP] - Recurring Volume Snapshot Custom Action Form
URL: https://github.com/apache/cloudstack-primate/pull/99#issuecomment-574522160
@utchoang there are some conflicts, can you merge latest master and fix the conflicts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #99: [WIP] -
Recurring Volume Snapshot Custom Action Form
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #99: [WIP] - Recurring Volume Snapshot Custom Action Form
URL: https://github.com/apache/cloudstack-primate/pull/99#issuecomment-574533221
@rhtyd I resolved the conflict PR. Please review again. Thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #99: [WIP] -
Recurring Volume Snapshot Custom Action Form
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #99: [WIP] - Recurring Volume Snapshot Custom Action Form
URL: https://github.com/apache/cloudstack-primate/pull/99#issuecomment-574078321
@rhtyd I would allow them to be all shown when the form is loaded, but it will affect other input (lag)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #99: [WIP] -
Recurring Volume Snapshot Custom Action Form
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #99: [WIP] - Recurring Volume Snapshot Custom Action Form
URL: https://github.com/apache/cloudstack-primate/pull/99#issuecomment-574072822
@utchoang but it breaks the UX for the user, as in the old UI we would list all the possible select options when the form is loaded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] svenvogel commented on issue #99: [WIP] -
Recurring Volume Snapshot Custom Action Form
Posted by GitBox <gi...@apache.org>.
svenvogel commented on issue #99: [WIP] - Recurring Volume Snapshot Custom Action Form
URL: https://github.com/apache/cloudstack-primate/pull/99#issuecomment-573888841
@utchoang from design looks good to me. if @rhtyd give okay after test we can merge it ... good work!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang commented on issue #99: [WIP] -
Recurring Volume Snapshot Custom Action Form
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #99: [WIP] - Recurring Volume Snapshot Custom Action Form
URL: https://github.com/apache/cloudstack-primate/pull/99#issuecomment-574054835
@rhtyd
1. I have merged with the last master.
2. Timezone is not shown in the first place because I only allow it to be shown when the search text is entered. Reference: https://www.antdv.com/components/select. A lot of timezones listed could cause lag when entering other text inputs
3. I will fix and update it on the next commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] rhtyd merged pull request #99: Recurring
Volume Snapshot Custom Action Form
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #99: Recurring Volume Snapshot Custom Action Form
URL: https://github.com/apache/cloudstack-primate/pull/99
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack-primate] utchoang edited a comment on issue #99: [WIP]
- Recurring Volume Snapshot Custom Action Form
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #99: [WIP] - Recurring Volume Snapshot Custom Action Form
URL: https://github.com/apache/cloudstack-primate/pull/99#issuecomment-574054835
@rhtyd
1. I have merged with the last master.
2. Timezone is not shown in the first place because I only allow it to be shown when the search text is entered. Reference: https://www.antdv.com/components/select. A lot of timezones listed could cause lag when entering other text inputs
3. I will fix and update it on the next PR of https://github.com/apache/cloudstack-primate/issues/87#issuecomment-573501920
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services