You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/21 10:05:25 UTC
[GitHub] [incubator-nuttx] ttnie opened a new pull request, #7383: CI: add example to sim
ttnie opened a new pull request, #7383:
URL: https://github.com/apache/incubator-nuttx/pull/7383
Signed-off-by: nietingting <ni...@xiaomi.com>
## Summary
add example include usrsocktest to sim
## Impact
no
## Testing
test on local
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7383: CI: add example to sim
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7383:
URL: https://github.com/apache/incubator-nuttx/pull/7383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ttnie commented on a diff in pull request #7383: CI: add example to sim
Posted by GitBox <gi...@apache.org>.
ttnie commented on code in PR #7383:
URL: https://github.com/apache/incubator-nuttx/pull/7383#discussion_r1002815874
##########
tools/ci/testrun/script/test_example/test_example.py:
##########
@@ -0,0 +1,44 @@
+#!/usr/bin/python3
+# encoding: utf-8
+import pytest
+
+pytestmark = [pytest.mark.common, pytest.mark.qemu]
+do_not_support = ["sabre-6quad", "rv-virt", "rv-virt64", "esp32c3-devkit", "bl602evb"]
+
+
+def test_hello(p):
+ ret = p.sendCommand("hello", "Hello, World!!")
+ assert ret == 0
+
+
+def test_helloxx(p):
+ if p.board in do_not_support:
+ pytest.skip("unsupported at {}".format(p.board))
+ if p.board == "best1600_ep":
+ if p.core == "tee":
+ pytest.skip("unsupported at {}-{}".format(p.board, p.core))
+ ret = p.sendCommand("helloxx", "Hello, World!!")
Review Comment:
I got the result like below, looks like different with yours. Image build by citest deconfig. @acassis
nsh> helloxx
helloxx_main: Saying hello from the dynamically constructed instance
CHelloWorld::HelloWorld: Hello, World!!
helloxx_main: Saying hello from the instance constructed on the stack
CHelloWorld::HelloWorld: Hello, World!!
helloxx_main: Saying hello from the statically constructed instance
CHelloWorld::HelloWorld: Hello, World!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7383: CI: add example to sim
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7383:
URL: https://github.com/apache/incubator-nuttx/pull/7383#discussion_r1004372513
##########
tools/ci/testrun/script/test_example/test_example.py:
##########
@@ -0,0 +1,36 @@
+#!/usr/bin/python3
+# encoding: utf-8
+import pytest
+
+pytestmark = [pytest.mark.common, pytest.mark.qemu]
+do_not_support = ["sabre-6quad", "rv-virt", "rv-virt64"]
Review Comment:
why not test c++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7383: CI: add example to sim
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7383:
URL: https://github.com/apache/incubator-nuttx/pull/7383#discussion_r1004742930
##########
tools/ci/testrun/script/test_example/test_example.py:
##########
@@ -0,0 +1,44 @@
+#!/usr/bin/python3
+# encoding: utf-8
+import pytest
+
+pytestmark = [pytest.mark.common, pytest.mark.qemu]
+do_not_support = ["sabre-6quad", "rv-virt", "rv-virt64", "esp32c3-devkit", "bl602evb"]
+
+
+def test_hello(p):
+ ret = p.sendCommand("hello", "Hello, World!!")
+ assert ret == 0
+
+
+def test_helloxx(p):
+ if p.board in do_not_support:
+ pytest.skip("unsupported at {}".format(p.board))
+ if p.board == "best1600_ep":
+ if p.core == "tee":
+ pytest.skip("unsupported at {}-{}".format(p.board, p.core))
+ ret = p.sendCommand("helloxx", "Hello, World!!")
Review Comment:
@acassis both will print to console:
https://github.com/apache/incubator-nuttx-apps/blob/master/examples/helloxx/helloxx_main.cxx#L67-L78
so it's fine to check "Hello, World!!".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7383: CI: add example to sim
Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #7383:
URL: https://github.com/apache/incubator-nuttx/pull/7383#discussion_r1001813028
##########
tools/ci/testrun/script/test_example/test_example.py:
##########
@@ -0,0 +1,44 @@
+#!/usr/bin/python3
+# encoding: utf-8
+import pytest
+
+pytestmark = [pytest.mark.common, pytest.mark.qemu]
+do_not_support = ["sabre-6quad", "rv-virt", "rv-virt64", "esp32c3-devkit", "bl602evb"]
+
+
+def test_hello(p):
+ ret = p.sendCommand("hello", "Hello, World!!")
+ assert ret == 0
+
+
+def test_helloxx(p):
+ if p.board in do_not_support:
+ pytest.skip("unsupported at {}".format(p.board))
+ if p.board == "best1600_ep":
+ if p.core == "tee":
+ pytest.skip("unsupported at {}-{}".format(p.board, p.core))
+ ret = p.sendCommand("helloxx", "Hello, World!!")
Review Comment:
I think the "helloxx" command doesn't return "Hello, World!!"! Did you test it?
It should return many different messages depending on which C++ features is enabled.
And finally it should return:
```
HelloWorld: mSecret=42
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ttnie commented on a diff in pull request #7383: CI: add example to sim
Posted by GitBox <gi...@apache.org>.
ttnie commented on code in PR #7383:
URL: https://github.com/apache/incubator-nuttx/pull/7383#discussion_r1005094312
##########
tools/ci/testrun/script/test_example/test_example.py:
##########
@@ -0,0 +1,36 @@
+#!/usr/bin/python3
+# encoding: utf-8
+import pytest
+
+pytestmark = [pytest.mark.common, pytest.mark.qemu]
+do_not_support = ["sabre-6quad", "rv-virt", "rv-virt64"]
Review Comment:
>
test on local c++ is works well on qemu, so enable on ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org