You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/11/20 16:01:07 UTC

[GitHub] [rocketmq] codecov-commenter commented on pull request #5556: create instance name with pid instead of pid+nanotime

codecov-commenter commented on PR #5556:
URL: https://github.com/apache/rocketmq/pull/5556#issuecomment-1321167892

   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/5556?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#5556](https://codecov.io/gh/apache/rocketmq/pull/5556?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c7978a1) into [develop](https://codecov.io/gh/apache/rocketmq/commit/21faa68b4cdd7f7103eebd811ed87154ff69e177?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (21faa68) will **decrease** coverage by `5.69%`.
   > The diff coverage is `35.02%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #5556      +/-   ##
   =============================================
   - Coverage      48.40%   42.71%   -5.70%     
   - Complexity      4621     8032    +3411     
   =============================================
     Files            555     1031     +476     
     Lines          36755    72743   +35988     
     Branches        4841     9614    +4773     
   =============================================
   + Hits           17793    31072   +13279     
   - Misses         16743    37737   +20994     
   - Partials        2219     3934    +1715     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/5556?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ache/rocketmq/acl/common/AuthenticationHeader.java](https://codecov.io/gh/apache/rocketmq/pull/5556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvY29tbW9uL0F1dGhlbnRpY2F0aW9uSGVhZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...pache/rocketmq/acl/common/AuthorizationHeader.java](https://codecov.io/gh/apache/rocketmq/pull/5556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvY29tbW9uL0F1dGhvcml6YXRpb25IZWFkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ava/org/apache/rocketmq/acl/common/Permission.java](https://codecov.io/gh/apache/rocketmq/pull/5556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvY29tbW9uL1Blcm1pc3Npb24uamF2YQ==) | `92.68% <0.00%> (ø)` | |
   | [...a/org/apache/rocketmq/broker/BrokerController.java](https://codecov.io/gh/apache/rocketmq/pull/5556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyQ29udHJvbGxlci5qYXZh) | `43.34% <ø> (-1.56%)` | :arrow_down: |
   | [...apache/rocketmq/broker/BrokerPreOnlineService.java](https://codecov.io/gh/apache/rocketmq/pull/5556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyUHJlT25saW5lU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ache/rocketmq/broker/client/net/Broker2Client.java](https://codecov.io/gh/apache/rocketmq/pull/5556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvY2xpZW50L25ldC9Ccm9rZXIyQ2xpZW50LmphdmE=) | `6.83% <0.00%> (+4.34%)` | :arrow_up: |
   | [...ketmq/broker/dledger/DLedgerRoleChangeHandler.java](https://codecov.io/gh/apache/rocketmq/pull/5556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZGxlZGdlci9ETGVkZ2VyUm9sZUNoYW5nZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...cketmq/broker/filter/MessageEvaluationContext.java](https://codecov.io/gh/apache/rocketmq/pull/5556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyL01lc3NhZ2VFdmFsdWF0aW9uQ29udGV4dC5qYXZh) | `30.76% <0.00%> (ø)` | |
   | [...rocketmq/broker/filtersrv/FilterServerManager.java](https://codecov.io/gh/apache/rocketmq/pull/5556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyc3J2L0ZpbHRlclNlcnZlck1hbmFnZXIuamF2YQ==) | `77.14% <ø> (+42.85%)` | :arrow_up: |
   | [.../broker/longpolling/LmqPullRequestHoldService.java](https://codecov.io/gh/apache/rocketmq/pull/5556/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbG9uZ3BvbGxpbmcvTG1xUHVsbFJlcXVlc3RIb2xkU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | ... and [1108 more](https://codecov.io/gh/apache/rocketmq/pull/5556/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org