You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/14 09:19:21 UTC
[GitHub] [incubator-devlake] keon94 opened a new issue, #3068: [Feature][Backend] Establish a standard error logging convention
keon94 opened a new issue, #3068:
URL: https://github.com/apache/incubator-devlake/issues/3068
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Currently the codebase is filled with random usages of logger.Error(err, "msg"). Calls to this function must be done where the given "err" is not going to be returned back to the caller. Otherwise we keep spamming the logs with the same error over and over. Another use-case is when a parent logger creates a child logger using logger.Nested(). If an error happens at the child level, the function that created the child should print the error and not pass it up to the parent logger.
### Use case
To summarize the description:
1. logger.Error(err, msg) with err != nil should be called when the err is not being returned to the caller
2. logger.Error(err, msg) with err != nil should be called at functions that create that logger. That err must not be returned back to the caller, but it's ok to create a new, non-wrapped error and pass that to the caller.
Otherwise, logger.Error with err != nil should not be called because it'll lead to confusing and spammy log message.
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Startrekzky commented on issue #3068: [Feature][Backend] Establish a standard error logging convention
Posted by GitBox <gi...@apache.org>.
Startrekzky commented on issue #3068:
URL: https://github.com/apache/incubator-devlake/issues/3068#issuecomment-1281025496
Is this one duplicated with #1447 or #2134 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #3068: [Feature][Backend] Establish a standard error logging convention
Posted by github-actions.
github-actions[bot] commented on issue #3068:
URL: https://github.com/apache/incubator-devlake/issues/3068#issuecomment-1404391556
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #3068: [Feature][Backend] Establish a standard error logging convention
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #3068:
URL: https://github.com/apache/incubator-devlake/issues/3068#issuecomment-1319385363
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #3068: [Feature][Backend] Establish a standard error logging convention
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #3068:
URL: https://github.com/apache/incubator-devlake/issues/3068#issuecomment-1681424637
This issue has been closed because it has been inactive for a long time. You can reopen it if you encounter the similar problem in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on issue #3068: [Feature][Backend] Establish a standard error logging convention
Posted by "keon94 (via GitHub)" <gi...@apache.org>.
keon94 commented on issue #3068:
URL: https://github.com/apache/incubator-devlake/issues/3068#issuecomment-1508075041
@Startrekzky not really. This has to do with where in our code should we be logging the errors to the backend log files. It has nothing to do with the user side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #3068: [Feature][Backend] Establish a standard error logging convention
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #3068:
URL: https://github.com/apache/incubator-devlake/issues/3068#issuecomment-1356916839
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on issue #3068: [Feature][Backend] Establish a standard error logging convention
Posted by GitBox <gi...@apache.org>.
keon94 commented on issue #3068:
URL: https://github.com/apache/incubator-devlake/issues/3068#issuecomment-1281547749
> Is this one duplicated with #1447 or #2134 ?
@Startrekzky No, this is standalone. This is about where in our code we should be logging error messages - not what the error messages should be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #3068: [Feature][Backend] Establish a standard error logging convention
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #3068:
URL: https://github.com/apache/incubator-devlake/issues/3068#issuecomment-1670476056
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Startrekzky commented on issue #3068: [Feature][Backend] Establish a standard error logging convention
Posted by "Startrekzky (via GitHub)" <gi...@apache.org>.
Startrekzky commented on issue #3068:
URL: https://github.com/apache/incubator-devlake/issues/3068#issuecomment-1508062241
Is this duplicated with #4282? Shall we close one of them? @klesh @keon94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #3068: [Feature][Backend] Establish a standard error logging convention
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #3068:
URL: https://github.com/apache/incubator-devlake/issues/3068#issuecomment-1463025548
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] closed issue #3068: [Feature][Backend] Establish a standard error logging convention
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #3068: [Feature][Backend] Establish a standard error logging convention
URL: https://github.com/apache/incubator-devlake/issues/3068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature][Backend] Establish a standard error logging convention [incubator-devlake]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #3068:
URL: https://github.com/apache/incubator-devlake/issues/3068#issuecomment-1773547311
This issue has been automatically marked as stale because it has been inactive for 60 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #3068: [Feature][Backend] Establish a standard error logging convention
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #3068:
URL: https://github.com/apache/incubator-devlake/issues/3068#issuecomment-1279610763
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #3068: [Feature][Backend] Establish a standard error logging convention
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #3068:
URL: https://github.com/apache/incubator-devlake/issues/3068#issuecomment-1451084015
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] closed issue #3068: [Feature][Backend] Establish a standard error logging convention
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #3068: [Feature][Backend] Establish a standard error logging convention
URL: https://github.com/apache/incubator-devlake/issues/3068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on issue #3068: [Feature][Backend] Establish a standard error logging convention
Posted by GitBox <gi...@apache.org>.
klesh commented on issue #3068:
URL: https://github.com/apache/incubator-devlake/issues/3068#issuecomment-1364840170
> What's the status of this issue? @klesh
Not sure, I think it is not yet started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Startrekzky commented on issue #3068: [Feature][Backend] Establish a standard error logging convention
Posted by GitBox <gi...@apache.org>.
Startrekzky commented on issue #3068:
URL: https://github.com/apache/incubator-devlake/issues/3068#issuecomment-1363941888
What's the status of this issue? @klesh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #3068: [Feature][Backend] Establish a standard error logging convention
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #3068:
URL: https://github.com/apache/incubator-devlake/issues/3068#issuecomment-1502502197
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature][Backend] Establish a standard error logging convention [incubator-devlake]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #3068:
URL: https://github.com/apache/incubator-devlake/issues/3068#issuecomment-1783950001
This issue has been closed because it has been inactive for a long time. You can reopen it if you encounter the similar problem in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature][Backend] Establish a standard error logging convention [incubator-devlake]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #3068: [Feature][Backend] Establish a standard error logging convention
URL: https://github.com/apache/incubator-devlake/issues/3068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org