[GitHub] [storm] agresch opened a new pull request #3176: STORM-3549 allow use of custom jaas conf files for Kafka

[GitBox <gi...@apache.org>]

agresch opened a new pull request #3176: STORM-3549 allow use of custom jaas conf files for Kafka
URL: https://github.com/apache/storm/pull/3176
 
 
   Previous to this change, client code would fetch a Configuration from a jaas conf file provided in the topo conf, set the Configuration globally, and then call Login. The Login code would fetch the singleton Configuration and use that to determine the jaas conf entries.
   
   The problem with this is that for external services such as Kafka, if they see a Configuration is set, they could default to using the set Configuration, which may not match the custom jaas conf specified by the user. Rather than setting the Configuration, when we call Login, we should just specify which jaas conf file to use for logging in and read that jaas file Configuration without setting it.
   
   Since the Configuration is now just being read when needed and not set, we do not need to pass it around. The file to use is already specified in the topoConf which is already passed around. A lot of clean up was done to remove the unnecessary parameter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services