[incubator-dlab] branch develop updated: [DLAB-1248] Fixed bottom header line is not drawn for all grid on FireFox

[an...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ankovalyshyn pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/incubator-dlab.git


The following commit(s) were added to refs/heads/develop by this push:
     new 05057ae  [DLAB-1248] Fixed bottom header line is not drawn for all grid on FireFox
     new f12b049  Merge pull request #440 from DG1202/DLAB-1248
05057ae is described below

commit 05057ae73a0a78d70174b96a20f10605633460ef
Author: Dmytro Gnatyshyn <di...@ukr.net>
AuthorDate: Fri Nov 22 14:04:48 2019 +0200

    [DLAB-1248] Fixed bottom header line is not drawn for all grid on FireFox
---
 .../detail-dialog/detail-dialog.component.html       | 20 ++++++++++----------
 .../resources-grid/resources-grid.component.scss     |  3 ++-
 2 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/detail-dialog/detail-dialog.component.html b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/detail-dialog/detail-dialog.component.html
index 425cb20..4ae01bd 100644
--- a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/detail-dialog/detail-dialog.component.html
+++ b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/detail-dialog/detail-dialog.component.html
@@ -47,7 +47,7 @@
             <p>Open following URL(s) in your browser to access this box:</p>
             <div class="links_block">
               <p *ngFor="let item of notebook.url">
-                <strong class="description">{{item.description}}: &#32;</strong>
+                <strong class="description">{{item.description}}: &nbsp;</strong>
                 <a
                   class="ellipsis"
                   matTooltip="{{item.url}}"
@@ -55,20 +55,20 @@
                   href="{{item.url}}"
                   target="_blank"
                 >
-                  &#32;{{item.url}}
+                  &nbsp;{{item.url}}
                 </a>
               </p>
             </div>
-            <p *ngIf="notebook.username">Node User: &#32;<strong>{{ notebook.username }}</strong></p>
-            <p *ngIf="notebook.password">Password: &#32;<strong>{{ notebook.password }}</strong></p>
+            <p *ngIf="notebook.username">Node User: &nbsp;<strong>{{ notebook.username }}</strong></p>
+            <p *ngIf="notebook.password">Password: &nbsp;<strong>{{ notebook.password }}</strong></p>
 
-            <p class="m-top-30">{{ DICTIONARY.personal_storage }}: &#32;</p>
+            <p class="m-top-30">{{ DICTIONARY.personal_storage }}: &nbsp;</p>
             <div class="links_block">
               <p *ngIf="DICTIONARY.cloud_provider === 'azure' && notebook.account_name">{{ DICTIONARY.account }}
                 <strong>{{ notebook.account_name}}</strong></p>
               <p *ngIf="notebook.bucket_name">{{ DICTIONARY.container }} <strong>{{ notebook.bucket_name }}</strong></p>
             </div>
-            <p>{{ DICTIONARY.collaboration_storage }}: &#32;</p>
+            <p>{{ DICTIONARY.collaboration_storage }}: &nbsp;</p>
             <div class="links_block">
               <p *ngIf="DICTIONARY.cloud_provider === 'azure' && notebook.shared_account_name">{{ DICTIONARY.account }}
                 <strong>{{ notebook.shared_account_name}}</strong></p>
@@ -78,11 +78,11 @@
             <br />
 
             <div *ngIf="DICTIONARY.cloud_provider === 'azure' && notebook.datalake_name">
-              <p>Data Lake Store: &#32;</p>
+              <p>Data Lake Store: &nbsp;</p>
               <div class="links_block">
-                <p>Data Lake Store Account: &#32;<strong>{{ notebook.datalake_name }}</strong></p>
-                <p>Personal folder: &#32;<strong>{{ notebook.datalake_directory }}</strong></p>
-                <p>Collaboration folder: &#32;<strong>{{ notebook.datalake_shared_directory }}</strong></p>
+                <p>Data Lake Store Account: &nbsp;<strong>{{ notebook.datalake_name }}</strong></p>
+                <p>Personal folder: &nbsp;<strong>{{ notebook.datalake_directory }}</strong></p>
+                <p>Collaboration folder: &nbsp;<strong>{{ notebook.datalake_shared_directory }}</strong></p>
               </div>
             </div>
 
diff --git a/services/self-service/src/main/resources/webapp/src/app/resources/resources-grid/resources-grid.component.scss b/services/self-service/src/main/resources/webapp/src/app/resources/resources-grid/resources-grid.component.scss
index e7d9907..0d9f9ae 100644
--- a/services/self-service/src/main/resources/webapp/src/app/resources/resources-grid/resources-grid.component.scss
+++ b/services/self-service/src/main/resources/webapp/src/app/resources/resources-grid/resources-grid.component.scss
@@ -92,6 +92,7 @@ table {
     width: 18%;
     padding-right: 5px;
     padding-left: 24px;
+    background-color: transparent;
   }
 
   .status-col,
@@ -122,13 +123,13 @@ table {
   .cost-col {
     width: 10%;
     text-align: center;
-
   }
 
   .actions-col {
     width: 10%;
     padding-right: 24px;
     text-align: right;
+    background-color: transparent;
   }
 }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@dlab.apache.org
For additional commands, e-mail: commits-help@dlab.apache.org