You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2022/07/05 07:27:43 UTC

[Impala-ASF-CR] IMPALA-11415: Add run-step-wait-all after Kudu data loading

Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18701


Change subject: IMPALA-11415: Add run-step-wait-all after Kudu data loading
......................................................................

IMPALA-11415: Add run-step-wait-all after Kudu data loading

IMPALA-11384 reveals an issue in testdata/bin/create-load-data.sh. If
$SKIP_METADATA_LOAD is true, all three of "Loading Kudu functional",
"Loading Kudu TPCH", and "Loading Hive UDFs" then ran in parallel in
the background. The later background step seemingly override the thrift
generated python code under shell/gen-py/hive_metastore/ and
shell/gen-py/beeswaxd/. This in turn cause sporadic python error upon
invocation of bin/load-data.py of the two former Kudu background steps.
Adding run-step-wait-all after the Kudu data loading seems to fix the
issue.

Testing:
- Successfully run create-load-data.sh with SKIP_METADATA_LOAD equals
  true.

Change-Id: I998cd1a1895f7c1bcaceb87e0592c6c0a0f6b4ea
---
M testdata/bin/create-load-data.sh
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/18701/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I998cd1a1895f7c1bcaceb87e0592c6c0a0f6b4ea
Gerrit-Change-Number: 18701
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-11415: Add run-step-wait-all after Kudu data loading

Posted by "Laszlo Gaal (Cloudera) (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18701 )

Change subject: IMPALA-11415: Add run-step-wait-all after Kudu data loading
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I998cd1a1895f7c1bcaceb87e0592c6c0a0f6b4ea
Gerrit-Change-Number: 18701
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jul 2022 09:11:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11415: Add run-step-wait-all after Kudu data loading

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18701 )

Change subject: IMPALA-11415: Add run-step-wait-all after Kudu data loading
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I998cd1a1895f7c1bcaceb87e0592c6c0a0f6b4ea
Gerrit-Change-Number: 18701
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jul 2022 09:12:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11415: Add run-step-wait-all after Kudu data loading

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18701 )

Change subject: IMPALA-11415: Add run-step-wait-all after Kudu data loading
......................................................................

IMPALA-11415: Add run-step-wait-all after Kudu data loading

IMPALA-11384 reveals an issue in testdata/bin/create-load-data.sh. If
$SKIP_METADATA_LOAD is true, all three of "Loading Kudu functional",
"Loading Kudu TPCH", and "Loading Hive UDFs" then ran in parallel in
the background. The later background step seemingly override the thrift
generated python code under shell/gen-py/hive_metastore/ and
shell/gen-py/beeswaxd/. This in turn cause sporadic python error upon
invocation of bin/load-data.py of the two former Kudu background steps.
Adding run-step-wait-all after the Kudu data loading seems to fix the
issue.

Testing:
- Successfully run create-load-data.sh with SKIP_METADATA_LOAD equals
  true.

Change-Id: I998cd1a1895f7c1bcaceb87e0592c6c0a0f6b4ea
Reviewed-on: http://gerrit.cloudera.org:8080/18701
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/bin/create-load-data.sh
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I998cd1a1895f7c1bcaceb87e0592c6c0a0f6b4ea
Gerrit-Change-Number: 18701
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11415: Add run-step-wait-all after Kudu data loading

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18701 )

Change subject: IMPALA-11415: Add run-step-wait-all after Kudu data loading
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8294/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I998cd1a1895f7c1bcaceb87e0592c6c0a0f6b4ea
Gerrit-Change-Number: 18701
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jul 2022 09:12:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11415: Add run-step-wait-all after Kudu data loading

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18701 )

Change subject: IMPALA-11415: Add run-step-wait-all after Kudu data loading
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10921/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I998cd1a1895f7c1bcaceb87e0592c6c0a0f6b4ea
Gerrit-Change-Number: 18701
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jul 2022 07:48:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11415: Add run-step-wait-all after Kudu data loading

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18701 )

Change subject: IMPALA-11415: Add run-step-wait-all after Kudu data loading
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I998cd1a1895f7c1bcaceb87e0592c6c0a0f6b4ea
Gerrit-Change-Number: 18701
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jul 2022 14:02:34 +0000
Gerrit-HasComments: No