[GitHub] merlimat commented on issue #1260: Recycle the AddResponse in WriteEntryProcessor

[GitBox <gi...@apache.org>]

merlimat commented on issue #1260: Recycle the AddResponse in WriteEntryProcessor
URL: https://github.com/apache/bookkeeper/pull/1260#issuecomment-373090323
 
 
   > are you OK with cherry pick to 4.6 branch, this is a importnat memory leak on bookie, no ?
   
   @eolivelli "forgetting" to recycle doesn't leave a memory leak. It just doesn't take advantage of the pooling. 
   
   You get an object from the recycler. If that is empty, it will allocated a new one (plust a `Handle` instance to track it). If it doesn't go back to pool, both the object and the "handle" are going to be be GCed. 
   
   It's typically ok to not recycle on uncommon error paths for example. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services