You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/04/22 20:33:49 UTC
[GitHub] [helix] NealSun96 opened a new pull request #1708: Fix flaky TestAssignableInstanceManager
NealSun96 opened a new pull request #1708:
URL: https://github.com/apache/helix/pull/1708
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Fixes #1707
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
If `testUpdateAssignableInstances` runs before `testGetAssignableInstanceMap`, `testGetAssignableInstanceMap` fails consistently because `testUpdateAssignableInstances` removed the old live instances that has already been populated.
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on pull request #1708: Fix flaky TestAssignableInstanceManager
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1708:
URL: https://github.com/apache/helix/pull/1708#issuecomment-825185403
Is it a required operation that a test remove the old live instance without recovering them before the next test starts? Can we just let testUpdateAssignableInstances to recover what has been changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 commented on pull request #1708: Fix flaky TestAssignableInstanceManager
Posted by GitBox <gi...@apache.org>.
NealSun96 commented on pull request #1708:
URL: https://github.com/apache/helix/pull/1708#issuecomment-825270774
This PR is ready to be merged, approved by @jiajunwang
Final commit message:
## Fix flaky TestAssignableInstanceManager ##
This PR enforces ordering of TestAssignableInstanceManager to fix flakiness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 commented on pull request #1708: Fix flaky TestAssignableInstanceManager
Posted by GitBox <gi...@apache.org>.
NealSun96 commented on pull request #1708:
URL: https://github.com/apache/helix/pull/1708#issuecomment-825202895
@jiajunwang I understand where you're coming from; we don't want to abuse "dependsOnMethod" for simple ordering.
However, in this case, `testUpdateAssignableInstances` is testing an "update" function which by design removes old live instance. I think the dependency is justified here. If I'm writing the tests I will combine the 3 test cases to 1 method, to be honest, because the "update" function should be tested strictly after calling the getters, to show that there is an actual update.
So I think "dependsOnMethod" is a better option here then recovering the old live instances; if you feel strongly against "dependsOnMethod", then I will combine the test cases because that's how I'd write them to begin with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang merged pull request #1708: Fix flaky TestAssignableInstanceManager
Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #1708:
URL: https://github.com/apache/helix/pull/1708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org