You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/03 02:47:41 UTC

[GitHub] [beam] jaketf commented on a change in pull request #11862: [BEAM-10141] HL7v2 io timestamps / watermark estimate

jaketf commented on a change in pull request #11862:
URL: https://github.com/apache/beam/pull/11862#discussion_r434278353



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java
##########
@@ -179,25 +189,51 @@ public static ListHL7v2Messages readAll(List<String> hl7v2Stores) {
     return new ListHL7v2Messages(StaticValueProvider.of(hl7v2Stores), StaticValueProvider.of(null));
   }
 
+  /** Read all HL7v2 Messages from multiple stores as sendTime {@link TimestampedValue}s. */
+  public static ListTimestampedHL7v2Messages readAllWithTimestamps(List<String> hl7v2Stores) {

Review comment:
       this is a good point.
   
   Unfortunately, I think having adding replacing the existing static methods with `withFilter` builder would be interface breaking. I've added this method to `ListHL7v2Messages` as it might be more natural for some to use.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org