You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/14 17:31:20 UTC

[GitHub] [incubator-seatunnel] asdf2014 opened a new pull request #1050: [SeaTunnel#1049] Add Dependabot to create PR to upgrade dependency automatically

asdf2014 opened a new pull request #1050:
URL: https://github.com/apache/incubator-seatunnel/pull/1050


   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[SeaTunnel #XXXX] [component] Title of the pull request", where *SeaTunnel #XXXX* should be replaced by the actual issue number.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   Fixes #1049
   
   ## Check list
   
   * [x] Code changed are covered with tests, or it does not need tests for reason:
   * [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] asdf2014 commented on pull request #1050: [SeaTunnel#1049] Add Dependabot to create PR to upgrade dependency automatically

Posted by GitBox <gi...@apache.org>.
asdf2014 commented on pull request #1050:
URL: https://github.com/apache/incubator-seatunnel/pull/1050#issuecomment-1014149510


   @CalvinKirs Yep, there may be a better solution that we can create a Github Action to auto modify the License part after DependaBot created a PR, so that we can merge it directly without any manual operation. What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1050: [Feature] [bot] Add Dependabot to create PR to upgrade dependency automatically

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1050:
URL: https://github.com/apache/incubator-seatunnel/pull/1050#issuecomment-1035911309


   Considering that we are going to release the binary package, and when the license changes, it is difficult for us to automatically modify it, so I closed it. If you have any good solutions later, you are welcome to discuss.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1050: [SeaTunnel#1049] Add Dependabot to create PR to upgrade dependency automatically

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1050:
URL: https://github.com/apache/incubator-seatunnel/pull/1050#issuecomment-1014668284


   > @CalvinKirs Yep, there may be a better solution that we can create a Github Action to auto modify the License part after DependaBot created a PR, so that we can merge it directly without any manual operation. What do you think?
   
   I still think that the modification of the license should be submitted to the corresponding issue, even if 99% of the issues are unnecessary. .you can also see that Flink is like this(Another point, I don't know if it can automatically judge about compatibility)
   Let's hear what others have to say.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1050: [SeaTunnel#1049] Add Dependabot to create PR to upgrade dependency automatically

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1050:
URL: https://github.com/apache/incubator-seatunnel/pull/1050#issuecomment-1014133180


   > Hi @CalvinKirs, thanks for your comment. Actually, we can add commit into the PR that created by DependaBot, like [this](https://github.com/apache/druid/pull/11367), so that we don't have to worry about the License. Unfortunately, the DependaBot doesn't support create issues instead of creating PRs. It is better to create PR, right, we can use PR to trigger our CI process, and verify the upgrade won't break anything. ๐Ÿ˜„
   > 
   > ![image](https://user-images.githubusercontent.com/8108788/149707716-3afded39-f103-44ef-9b05-50be0fed4cff.png)
   
   We need to modify it based on it, and it cannot be merged directly. Do you have any good solution for this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] CalvinKirs closed pull request #1050: [Feature] [bot] Add Dependabot to create PR to upgrade dependency automatically

Posted by GitBox <gi...@apache.org>.
CalvinKirs closed pull request #1050:
URL: https://github.com/apache/incubator-seatunnel/pull/1050


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1050: [SeaTunnel#1049] Add Dependabot to create PR to upgrade dependency automatically

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #1050:
URL: https://github.com/apache/incubator-seatunnel/pull/1050#issuecomment-1014106834


   hi, to upgrade the dependency version, you need to add the corresponding license statement (including the version), can we just create an issue reminder instead of creating a PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] asdf2014 commented on pull request #1050: [SeaTunnel#1049] Add Dependabot to create PR to upgrade dependency automatically

Posted by GitBox <gi...@apache.org>.
asdf2014 commented on pull request #1050:
URL: https://github.com/apache/incubator-seatunnel/pull/1050#issuecomment-1014129260


   Hi @CalvinKirs, thanks for your comment. Actually, we can add commit into the PR that created by DependaBot, like [this](https://github.com/apache/druid/pull/11367), so that we don't have to worry about the License. Unfortunately, the DependaBot doesn't support create issues instead of creating PRs. It is better to create PR, right, we can use PR to trigger our CI process, and verify the upgrade won't break anything. :smile:
   
   ![image](https://user-images.githubusercontent.com/8108788/149707716-3afded39-f103-44ef-9b05-50be0fed4cff.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] asdf2014 commented on pull request #1050: [SeaTunnel#1049] Add Dependabot to create PR to upgrade dependency automatically

Posted by GitBox <gi...@apache.org>.
asdf2014 commented on pull request #1050:
URL: https://github.com/apache/incubator-seatunnel/pull/1050#issuecomment-1014692696


   @CalvinKirs Sure, itโ€™s up to you, and also welcome any other comments :smiley:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org