[GitHub] [iotdb] jixuan1989 commented on a change in pull request #3067: [IOTDB-1059] Support sql statement insert without timestamp

[GitBox <gi...@apache.org>]

jixuan1989 commented on a change in pull request #3067:
URL: https://github.com/apache/iotdb/pull/3067#discussion_r628899290



##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/crud/InsertRowPlan.java
##########
@@ -582,6 +585,16 @@ public void recoverFromFailure() {
   @Override
   public void checkIntegrity() throws QueryProcessException {
     super.checkIntegrity();
+    List measurementList = Arrays.asList(this.measurements);

Review comment:
       why add this snippet?

##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/crud/InsertRowPlan.java
##########
@@ -582,6 +582,12 @@ public void recoverFromFailure() {
   @Override
   public void checkIntegrity() throws QueryProcessException {
     super.checkIntegrity();
+    if (this.measurements.length == 1) {

Review comment:
       confusing..
   how about if the measurements.length >1?
   e.g., `insert into (time,  time) values ...  `
   how to understand the second `time`?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org