Re: [PR] [MBUILDCACHE-87] - Checksum should consider plugin dependencies [maven-build-cache-extension]

["AlexanderAshitkin (via GitHub)" <gi...@apache.org>]

AlexanderAshitkin commented on code in PR #146:
URL: https://github.com/apache/maven-build-cache-extension/pull/146#discussion_r1623244666


##########
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##########
@@ -620,14 +631,26 @@ private static boolean isReadable(Path entry) throws IOException {
     }
 
     private SortedMap<String, String> getMutableDependencies() throws IOException {
+        return getMutableDependenciesHashes("", project.getDependencies());
+    }
+
+    private SortedMap<String, String> getMutablePluginDependencies() throws IOException {
+        SortedMap<String, String> fullMap = new TreeMap<>();
+        for (Plugin plugin : project.getBuildPlugins()) {
+            if (config.isPluginDependenciesExcluded(plugin)) {
+                continue;
+            }
+            fullMap.putAll(getMutableDependenciesHashes(
+                    KeyUtils.getVersionlessArtifactKey(repoSystem.createPluginArtifact(plugin)) + "|",

Review Comment:
   what is the goal of adding `"|"` to the key?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org