You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "boneanxs (via GitHub)" <gi...@apache.org> on 2023/02/01 09:16:48 UTC

[GitHub] [incubator-celeborn] boneanxs opened a new pull request, #1195: [CELEBORN-258][FOLLOW UP] `sbin/restart-worker.sh` should also import the `sbin/celeborn-config.sh`

boneanxs opened a new pull request, #1195:
URL: https://github.com/apache/incubator-celeborn/pull/1195

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   Follow up the pr #1192 to read the `sbin/celeborn-config.sh` firstly, otherwise `CELEBORN_WORKER_MEMORY` and `CELEBORN_WORKER_OFFHEAP_MEMORY ` set in the `celeborn-env.sh` will not take effect 
   
   ### Why are the changes needed?
   
   If users set `CELEBORN_WORKER_MEMORY` and `CELEBORN_WORKER_OFFHEAP_MEMORY ` in the `celeborn-env.sh`, calling `sbin/restart-worker.sh` actually omit these settings.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   ### How was this patch tested?
   
   MT.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] AngersZhuuuu merged pull request #1195: [CELEBORN-258][FOLLOW UP] `sbin/restart-worker.sh` should also import the `sbin/celeborn-config.sh`

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu merged PR #1195:
URL: https://github.com/apache/incubator-celeborn/pull/1195


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org