You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/29 14:34:19 UTC

[GitHub] [kafka] inponomarev commented on pull request #9107: KAFKA-5488: Add type-safe split() operator

inponomarev commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-752098770


   > Can you also update the docs for Kafka Streams and the 2.8 upgrade guide in this PR.
   
   The documentation had been already updated (see changes in `docs/streams/developer-guide/dsl-api.html`)
   
   I also modified  `docs/upgrade.html` -- should I add something more here, like code examples?
   
   Another question: CI checks fail because of usage of deprecated `branch` method in `streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/KStream.scala`. Since I'm not a Scala user, I have no idea of what should be done here. 
   
   Most likely we should deprecate the `branch` method and add a wrapper for the new `split` method, but I don't know how to do this correctly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org