You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucy.apache.org by "Peter Karman (JIRA)" <ji...@apache.org> on 2009/11/21 06:28:39 UTC
[jira] Created: (LUCY-70) Charmonizer static functions require S_
prefix like the rest of Lucy code
Charmonizer static functions require S_ prefix like the rest of Lucy code
-------------------------------------------------------------------------
Key: LUCY-70
URL: https://issues.apache.org/jira/browse/LUCY-70
Project: Lucy
Issue Type: Task
Components: Charmonizer
Reporter: Peter Karman
Priority: Minor
The Charmonizer code predates the convention used elsewhere in Lucy of prefixing static functions with S_.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (LUCY-70) Charmonizer static functions require S_
prefix like the rest of Lucy code
Posted by "Marvin Humphrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCY-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marvin Humphrey resolved LUCY-70.
---------------------------------
Resolution: Fixed
Assignee: Marvin Humphrey
Committed as r882834.
Thanks!
> Charmonizer static functions require S_ prefix like the rest of Lucy code
> -------------------------------------------------------------------------
>
> Key: LUCY-70
> URL: https://issues.apache.org/jira/browse/LUCY-70
> Project: Lucy
> Issue Type: Task
> Components: Charmonizer
> Reporter: Peter Karman
> Assignee: Marvin Humphrey
> Priority: Minor
> Attachments: S_-prefix.patch
>
>
> The Charmonizer code predates the convention used elsewhere in Lucy of prefixing static functions with S_.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCY-70) Charmonizer static functions require S_
prefix like the rest of Lucy code
Posted by "Marvin Humphrey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCY-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780919#action_12780919 ]
Marvin Humphrey commented on LUCY-70:
-------------------------------------
Looks good.
I went ahead and applied the same transform to src/charmonizer/charmonize.c.
This are a little weird, but I'm going to commit anyway:
{code}
static void
S_TestBatch_destroy(TestBatch *batch);
{code}
TestBatch should probably be broken out into a separate file, in which case
that would become S_destroy like its brethren.
> Charmonizer static functions require S_ prefix like the rest of Lucy code
> -------------------------------------------------------------------------
>
> Key: LUCY-70
> URL: https://issues.apache.org/jira/browse/LUCY-70
> Project: Lucy
> Issue Type: Task
> Components: Charmonizer
> Reporter: Peter Karman
> Priority: Minor
> Attachments: S_-prefix.patch
>
>
> The Charmonizer code predates the convention used elsewhere in Lucy of prefixing static functions with S_.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCY-70) Charmonizer static functions require S_
prefix like the rest of Lucy code
Posted by "Peter Karman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCY-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Karman updated LUCY-70:
-----------------------------
Attachment: S_-prefix.patch
Patch implements the S_ prefix for Charmonizer code.
> Charmonizer static functions require S_ prefix like the rest of Lucy code
> -------------------------------------------------------------------------
>
> Key: LUCY-70
> URL: https://issues.apache.org/jira/browse/LUCY-70
> Project: Lucy
> Issue Type: Task
> Components: Charmonizer
> Reporter: Peter Karman
> Priority: Minor
> Attachments: S_-prefix.patch
>
>
> The Charmonizer code predates the convention used elsewhere in Lucy of prefixing static functions with S_.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.