You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by markap14 <gi...@git.apache.org> on 2016/07/20 16:39:59 UTC
[GitHub] nifi pull request #689: NIFI-2305: Do not run processors that are marked as ...
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/689
NIFI-2305: Do not run processors that are marked as Primary Node Only\u2026
\u2026 if disconnected from cluster
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-2305-0.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/689.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #689
----
commit 05c9cc6b790ef53c6cf1e5f6ceaba85122e8ccf1
Author: Mark Payne <ma...@hotmail.com>
Date: 2016-07-20T16:39:26Z
NIFI-2305: Do not run processors that are marked as Primary Node Only if disconnected from cluster
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #689: NIFI-2305: Do not run processors that are marked as Primary...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/689
Reviewing this and came across a state that I'm not if its intended or not.
ncm and 2 node cluster with a flow GenerateFF (primary node only) -> LogAttribute
set a break point on line 3809 of FlowController.java to cause the primary node to stop sending heartbeats
after 45 seconds of not receiving heartbeats the NCM disconnects the node from the cluster
at that time observe that the FFs are no longer getting logged (assume because the GenerateFF is no longer being scheduled)
Also I cannot access the UI of the node that is disconnected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #689: NIFI-2305: Do not run processors that are marked as Primary...
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/689
@markap14 @JPercivall
Given we getting well into 1.2, should this PR still go ahead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #689: NIFI-2305: Do not run processors that are marked as Primary...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/689
FYI, in order to track for 0.8 I created a separate Jira ticket for adding this 0.x and closed the 1.0 ticket. Please update the commit when you get a chance.
[1] https://issues.apache.org/jira/browse/NIFI-2433
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #689: NIFI-2305: Do not run processors that are marked as ...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 closed the pull request at:
https://github.com/apache/nifi/pull/689
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #689: NIFI-2305: Do not run processors that are marked as Primary...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/689
@markap14 I think we should close this. It is already fixed on the 1.x line. Doing a stale PR sweep and this comes up. Would like to close it out or push it across the finish line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #689: NIFI-2305: Do not run processors that are marked as Primary...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/689
Sounds good to me. Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #689: NIFI-2305: Do not run processors that are marked as Primary...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/689
I'm in favor of closing it, sound good @markap14?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---