You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Chao Sun <ch...@cloudera.com> on 2015/05/29 07:52:42 UTC
Review Request 34798: HIVE-10788 - Change sort_array to support
non-primitive types
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34798/
-----------------------------------------------------------
Review request for hive and Alexander Pivovarov.
Bugs: HIVE-10788
https://issues.apache.org/jira/browse/HIVE-10788
Repository: hive-git
Description
-------
Currently sort_array only support primitive types. As we already support comparison between non-primitive types, it makes sense to remove this restriction.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSortArray.java 2d6d58c
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFSortArray.java PRE-CREATION
ql/src/test/queries/clientnegative/udf_sort_array_wrong3.q 034de06
ql/src/test/queries/clientpositive/udf_sort_array.q 313bcf8
ql/src/test/results/clientnegative/udf_sort_array_wrong1.q.out 075f49b
ql/src/test/results/clientnegative/udf_sort_array_wrong2.q.out c068ecd
ql/src/test/results/clientnegative/udf_sort_array_wrong3.q.out abf7124
ql/src/test/results/clientpositive/udf_sort_array.q.out 9631c2d
Diff: https://reviews.apache.org/r/34798/diff/
Testing
-------
I added a few tests to udf_sort_array.q, and also added unit tests.
Thanks,
Chao Sun
Re: Review Request 34798: HIVE-10788 - Change sort_array to support
non-primitive types
Posted by Alexander Pivovarov <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34798/#review85852
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Pivovarov
On May 29, 2015, 5:52 a.m., Chao Sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34798/
> -----------------------------------------------------------
>
> (Updated May 29, 2015, 5:52 a.m.)
>
>
> Review request for hive and Alexander Pivovarov.
>
>
> Bugs: HIVE-10788
> https://issues.apache.org/jira/browse/HIVE-10788
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently sort_array only support primitive types. As we already support comparison between non-primitive types, it makes sense to remove this restriction.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSortArray.java 2d6d58c
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFSortArray.java PRE-CREATION
> ql/src/test/queries/clientnegative/udf_sort_array_wrong3.q 034de06
> ql/src/test/queries/clientpositive/udf_sort_array.q 313bcf8
> ql/src/test/results/clientnegative/udf_sort_array_wrong1.q.out 075f49b
> ql/src/test/results/clientnegative/udf_sort_array_wrong2.q.out c068ecd
> ql/src/test/results/clientnegative/udf_sort_array_wrong3.q.out abf7124
> ql/src/test/results/clientpositive/udf_sort_array.q.out 9631c2d
>
> Diff: https://reviews.apache.org/r/34798/diff/
>
>
> Testing
> -------
>
> I added a few tests to udf_sort_array.q, and also added unit tests.
>
>
> Thanks,
>
> Chao Sun
>
>