[GitHub] [druid] capistrant commented on a change in pull request #10280: recreate the balancer executor only when needed

[GitBox <gi...@apache.org>]

capistrant commented on a change in pull request #10280:
URL: https://github.com/apache/druid/pull/10280#discussion_r485145022



##########
File path: server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java
##########
@@ -647,22 +678,53 @@ private void stopBeingLeader()
     return ImmutableList.of(compactSegments);
   }
 
-  private class DutiesRunnable implements Runnable
+  protected class DutiesRunnable implements Runnable

Review comment:
       I see DutiesRunnable used to be public with a protected constructor but was flipped to private/private in [pull 9644](https://github.com/apache/druid/pull/9644) ... Now we are flipping the class and constructor to protected. I want to make sure @maytasm sees this PR and can comment on the idea of going back to protected from private.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org