You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by rvsoni <gi...@git.apache.org> on 2016/10/28 01:55:21 UTC
[GitHub] activemq-artemis pull request #871: ARTEMIS-332 avoid shutting down the serv...
GitHub user rvsoni opened a pull request:
https://github.com/apache/activemq-artemis/pull/871
ARTEMIS-332 avoid shutting down the server after interrupted threads on divert (copy and rename)
Bug 1168712 \u2013 HQ222010: Critical IO Error, shutting down the server after interrupted threads on divert (copy and rename)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rvsoni/activemq-artemis master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/871.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #871
----
commit bf70fc6e91dab3f2db3d03989ca7af717b1e76c5
Author: Ravi Soni <rv...@hotmail.com>
Date: 2016-10-28T01:47:35Z
ARTEMIS-332 avoid shutting down the server after interrupted threads on
divert (copy and rename)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #871: ARTEMIS-332 avoid shutting down the server afte...
Posted by rvsoni <gi...@git.apache.org>.
Github user rvsoni commented on the issue:
https://github.com/apache/activemq-artemis/pull/871
We ware having some issue in NFS server used as shared store for journals and largemessage store, so write to large file got interrupted due to client close connection.
class NIOSequentialFile is haveing fix related to handling ClosedChannelException, it was only missed in two method (copy,remane) of AbstractSequentialFile which caused server shutdown.
We got this issue in HornetQ, and Artemis also has same code base.
This is related to https://bugzilla.redhat.com/show_bug.cgi?id=1296634
```
16:40:38,947 WARN [org.hornetq.core.server] (Old I/O server worker (parentId: 1527657329, [id: 0x5b0e3371, /10.100.40.199:5445]), runningThrea
d=Thread-7391 (HornetQ-remoting-threads-HornetQServerImpl::serverUUID=5a56fa30-e71f-11e5-8294-e926e7e7d82c-1188589496-865516095)) HQ222010: Cri
tical IO Error, shutting down the server. file=NIOSequentialFile /opt/idsk/shared/messaging/live/largemessages/8653688763.msg, message=null: Ho
rnetQException[errorType=IO_ERROR message=null]
at org.hornetq.core.journal.impl.NIOSequentialFile.internalWrite(NIOSequentialFile.java:359) [hornetq-journal-2.3.25.SP8-redhat-1.jar:2
.3.25.SP8-redhat-1]
at org.hornetq.core.journal.impl.NIOSequentialFile.writeDirect(NIOSequentialFile.java:312) [hornetq-journal-2.3.25.SP8-redhat-1.jar:2.3
.25.SP8-redhat-1]
at org.hornetq.core.journal.impl.AbstractSequentialFile.copyTo(AbstractSequentialFile.java:130) [hornetq-journal-2.3.25.SP8-redhat-1.ja
r:2.3.25.SP8-redhat-1]
at org.hornetq.core.persistence.impl.journal.LargeServerMessageImpl.finishCopy(LargeServerMessageImpl.java:326) [hornetq-server-2.3.25.
SP8-redhat-1.jar:2.3.25.SP8-redhat-1]
at org.hornetq.core.server.impl.DivertImpl.route(DivertImpl.java:94) [hornetq-server-2.3.25.SP8-redhat-1.jar:2.3.25.SP8-redhat-1]
at org.hornetq.core.postoffice.impl.DivertBinding.route(DivertBinding.java:108) [hornetq-server-2.3.25.SP8-redhat-1.jar:2.3.25.SP8-redh
at-1]
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #871: ARTEMIS-332 avoid shutting down the server afte...
Posted by rvsoni <gi...@git.apache.org>.
Github user rvsoni commented on the issue:
https://github.com/apache/activemq-artemis/pull/871
Before code check in, I did run mvn -Pdev install -DskipTests=true and compile code with out any checkstyle error/warn message.
Ravi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #871: ARTEMIS-332 avoid shutting down the serv...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/871#discussion_r85463326
--- Diff: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/AbstractSequentialFile.java ---
@@ -124,6 +125,9 @@ public void copyTo(SequentialFile newFileName) throws Exception {
newFileName.close();
this.close();
}
+ catch (ClosedChannelException e) {
--- End diff --
in what situation this would happen?
an interrupted exception here means the VM has been interrupted, in what situation the server should be avoided from going down?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #871: ARTEMIS-332 avoid shutting down the server afte...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/871
It wasn't rebased against master. I fixed it and merged it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #871: ARTEMIS-332 avoid shutting down the serv...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/871#discussion_r85463363
--- Diff: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/AbstractSequentialFile.java ---
@@ -124,6 +125,9 @@ public void copyTo(SequentialFile newFileName) throws Exception {
newFileName.close();
this.close();
}
--- End diff --
there's a checkstyle issue here.
run this on your copy:
```
mvn -Pdev install -DskipTests=true
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #871: ARTEMIS-332 avoid shutting down the serv...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/871
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---