[jira] [Commented] (OFBIZ-13654) Make MultiTrustManager reject untrusted certificates when its all-trusted properties are missing or empty

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-13654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18124488#comment-18124488 ] 

ASF subversion and git services commented on OFBIZ-13654:
---------------------------------------------------------

Commit ec6adeae8d9f371b23171b87a6cccddd2d43e074 in ofbiz-framework's branch refs/heads/trunk from Mridul Pathak
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ec6adeae8d ]

Fixed: Reject untrusted certificates in MultiTrustManager when the all-trusted properties are missing or empty (OFBIZ-13654)

MultiTrustManager ignored a certificate validation failure when the property server.all-trusted or client.all-trusted of certificate.properties was "true", and it read both properties with the default "true". A certificate.properties without these entries, or with an empty value, therefore silently disabled the certificate validation of the outgoing connections and of the client certificates. The shipped file sets both to false, so a default installation was not affected.

Both properties are now read with the default "false", so that a missing or empty value keeps the validation on and only an explicit "true" turns it off.


> Make MultiTrustManager reject untrusted certificates when its all-trusted properties are missing or empty
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-13654
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-13654
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework/base
>    Affects Versions: Upcoming Branch, 24.09.07
>            Reporter: Mridul Pathak
>            Assignee: Mridul Pathak
>            Priority: Minor
>
> MultiTrustManager validates certificates against the configured trust anchors, but when the validation fails it ignores the failure if the property server.all-trusted (outgoing connections) or client.all-trusted (client certificates) of certificate.properties is "true". The code reads both properties with the default "true", so a certificate.properties without these entries, or with an empty value, silently disables the certificate validation. The shipped file sets both to false, so a default installation is not affected.
> h3. Proposed change
> Read both properties with the default "false", so that a missing or empty value keeps the validation on and only an explicit "true" disables it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)