You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:30:42 UTC
Re: Review Request 51700: Add `FrameworkAdded` event to master event
stream.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51700/#review167450
-----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews.
- Joris Van Remoortere
On Nov. 8, 2016, 5:43 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51700/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2016, 5:43 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, haosdent huang, and Vinod Kone.
>
>
> Bugs: MESOS-6101
> https://issues.apache.org/jira/browse/MESOS-6101
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changes included:
> - Moving `model()` helper function to common/protobuf_utils;
> - Definition of event and response;
> - Sending event from master;
> - new test.
>
>
> Diffs
> -----
>
> include/mesos/master/master.proto 1ea79fd7ecd9c2b7e94718fc8c7779d1051583db
> include/mesos/v1/master/master.proto 58dc65006658f47bb752ee1c0c1520ee3cc03bd7
> src/common/protobuf_utils.hpp 3324838f0a54491024b3e26ddf38afbfad31b8e4
> src/common/protobuf_utils.cpp 8c4a7264080385789157703b05b42716fb0563b3
> src/master/http.cpp 52dd80b856cf2317c0b73ba54bf501696786088d
> src/master/master.cpp d94a8510c4cee9c010706f79caf27ef4a10b41a8
> src/tests/api_tests.cpp e440d1b44fb0b40dd1f68209c71e5ca0cd19f4fb
>
>
> Diff: https://reviews.apache.org/r/51700/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>