You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by an...@apache.org on 2013/05/23 19:45:51 UTC
svn commit: r1485786 - /tomee/tomee/trunk/pom.xml
Author: andygumbrecht
Date: Thu May 23 17:45:51 2013
New Revision: 1485786
URL: http://svn.apache.org/r1485786
Log:
Use property
Modified:
tomee/tomee/trunk/pom.xml
Modified: tomee/tomee/trunk/pom.xml
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/pom.xml?rev=1485786&r1=1485785&r2=1485786&view=diff
==============================================================================
--- tomee/tomee/trunk/pom.xml (original)
+++ tomee/tomee/trunk/pom.xml Thu May 23 17:45:51 2013
@@ -90,7 +90,7 @@
<properties>
- <openejb.version>4.6.0-SNAPSHOT</openejb.version>
+ <openejb.version>${project.version}</openejb.version>
<tomee.version>1.6.0-SNAPSHOT</tomee.version>
<!-- Maven module versions -->
Re: Fwd: svn commit: r1485786 - /tomee/tomee/trunk/pom.xml
Posted by Romain Manni-Bucau <rm...@gmail.com>.
i had the same thought but that's not possible (not logical, we'll lost
users...)
we can split tomee and openejb in 2 projects but then the version will
still be in tomee subproject. An alternative is a small groovy script in
mvn to set this var (if project.version startswith 1 -> 4 else nothing)
That said using sed on both versions helps releasing ;)
*Romain Manni-Bucau*
*Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
*Blog: **http://rmannibucau.wordpress.com/*<http://rmannibucau.wordpress.com/>
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*
2013/5/24 AndyG <an...@orprovision.com>
> Ouch, see what you mean. But this still seems wrong somehow to have this
> hard
> coded?
>
> It makes versioning a two step process outside the scope of current maven
> modules. I am still playing with the push snapshot to local repo and a new
> version.
>
> Maybe aligning the OpenEJB version with TomEE is worth thinking about?
>
>
>
> --
> View this message in context:
> http://openejb.979440.n4.nabble.com/Fwd-svn-commit-r1485786-tomee-tomee-trunk-pom-xml-tp4663194p4663197.html
> Sent from the OpenEJB Dev mailing list archive at Nabble.com.
>
Re: Fwd: svn commit: r1485786 - /tomee/tomee/trunk/pom.xml
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Right but then you'll need to think really to what it means, sometimes it
will be very deep (3/4 levels) and i think it is still an issue in other
projects (we have it in tck IIRC)
*Romain Manni-Bucau*
*Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
*Blog: **http://rmannibucau.wordpress.com/*<http://rmannibucau.wordpress.com/>
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*
2013/5/24 AndyG <an...@orprovision.com>
> There are also several usages that could be replaced by ${parent.version}
> or
> ${parent.parent.version} ...if that would work.
>
>
>
> --
> View this message in context:
> http://openejb.979440.n4.nabble.com/Fwd-svn-commit-r1485786-tomee-tomee-trunk-pom-xml-tp4663194p4663201.html
> Sent from the OpenEJB Dev mailing list archive at Nabble.com.
>
Re: Fwd: svn commit: r1485786 - /tomee/tomee/trunk/pom.xml
Posted by AndyG <an...@orprovision.com>.
There are also several usages that could be replaced by ${parent.version} or
${parent.parent.version} ...if that would work.
--
View this message in context: http://openejb.979440.n4.nabble.com/Fwd-svn-commit-r1485786-tomee-tomee-trunk-pom-xml-tp4663194p4663201.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.
Re: Fwd: svn commit: r1485786 - /tomee/tomee/trunk/pom.xml
Posted by AndyG <an...@orprovision.com>.
I guess this only changes at runtime. To deploy to a lan repo the poms have
to be physically changed before upload.
Currently I add and use versions-maven-plugin 1.3.1 on an svn export, and
search and replace for the left-overs. I don't do it that often (only when
all tests pass and something significant has changed for the better). My
internal version is 4.6.OV.3
This looks promising though, I will have a play with it:
http://code.google.com/p/maven-replacer-plugin/
--
View this message in context: http://openejb.979440.n4.nabble.com/Fwd-svn-commit-r1485786-tomee-tomee-trunk-pom-xml-tp4663194p4663203.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.
Re: Fwd: svn commit: r1485786 - /tomee/tomee/trunk/pom.xml
Posted by Romain Manni-Bucau <rm...@gmail.com>.
i'd do it in parent pom in initialize phase (hope it is early enough) then
something like :
<plugins>
<plugin>
<groupId>org.codehaus.gmaven</groupId>
<artifactId>gmaven-plugin</artifactId>
<version>1.3</version>
<executions>
<execution>
<id>configure-adapters</id>
<phase>initialize</phase>
<goals>
<goal>execute</goal>
</goals>
</execution>
</executions>
<configuration>
<source>
def props = project.properties
project.properties['openejb.version'] = '4' +
project.properties['project.version'].substring(1)
</source>
</configuration>
</plugin>
if it is too late not sure we can find something working
*Romain Manni-Bucau*
*Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
*Blog: **http://rmannibucau.wordpress.com/*<http://rmannibucau.wordpress.com/>
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*
2013/5/24 AndyG <an...@orprovision.com>
> Is there already a maven module that can be used to search poms and change
> this value?
>
>
>
> --
> View this message in context:
> http://openejb.979440.n4.nabble.com/Fwd-svn-commit-r1485786-tomee-tomee-trunk-pom-xml-tp4663194p4663199.html
> Sent from the OpenEJB Dev mailing list archive at Nabble.com.
>
Re: Fwd: svn commit: r1485786 - /tomee/tomee/trunk/pom.xml
Posted by AndyG <an...@orprovision.com>.
Is there already a maven module that can be used to search poms and change
this value?
--
View this message in context: http://openejb.979440.n4.nabble.com/Fwd-svn-commit-r1485786-tomee-tomee-trunk-pom-xml-tp4663194p4663199.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.
Re: Fwd: svn commit: r1485786 - /tomee/tomee/trunk/pom.xml
Posted by AndyG <an...@orprovision.com>.
Ouch, see what you mean. But this still seems wrong somehow to have this hard
coded?
It makes versioning a two step process outside the scope of current maven
modules. I am still playing with the push snapshot to local repo and a new
version.
Maybe aligning the OpenEJB version with TomEE is worth thinking about?
--
View this message in context: http://openejb.979440.n4.nabble.com/Fwd-svn-commit-r1485786-tomee-tomee-trunk-pom-xml-tp4663194p4663197.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.
Fwd: svn commit: r1485786 - /tomee/tomee/trunk/pom.xml
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Hi
Can't be done since it is contextual to current pom and not the one where
it is defined :(
---------- Message transféré ----------
De : <an...@apache.org>
Date : 23 mai 2013 19:46
Objet : svn commit: r1485786 - /tomee/tomee/trunk/pom.xml
À : <co...@tomee.apache.org>
Author: andygumbrecht
Date: Thu May 23 17:45:51 2013
New Revision: 1485786
URL: http://svn.apache.org/r1485786
Log:
Use property
Modified:
tomee/tomee/trunk/pom.xml
Modified: tomee/tomee/trunk/pom.xml
URL:
http://svn.apache.org/viewvc/tomee/tomee/trunk/pom.xml?rev=1485786&r1=1485785&r2=1485786&view=diff
==============================================================================
--- tomee/tomee/trunk/pom.xml (original)
+++ tomee/tomee/trunk/pom.xml Thu May 23 17:45:51 2013
@@ -90,7 +90,7 @@
<properties>
- <openejb.version>4.6.0-SNAPSHOT</openejb.version>
+ <openejb.version>${project.version}</openejb.version>
<tomee.version>1.6.0-SNAPSHOT</tomee.version>
<!-- Maven module versions -->