You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/21 16:31:19 UTC

[GitHub] [airflow] mik-laj opened a new pull request #7488: [AIRFLOW-6867] Decouple DagBag and TaskInstance

mik-laj opened a new pull request #7488: [AIRFLOW-6867] Decouple DagBag and TaskInstance
URL: https://github.com/apache/airflow/pull/7488
 
 
   DagBag should be responsible for loading DAGs. The Scheduler should be responsible for managing task instance.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #7488: [AIRFLOW-6867] Decouple DagBag and TaskInstance

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7488: [AIRFLOW-6867] Decouple DagBag and TaskInstance
URL: https://github.com/apache/airflow/pull/7488#issuecomment-589834902
 
 
   @tooptoop4 Thanks. I will try to correct all types in the schedule when I finish optimizing the scheduler. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7488: [AIRFLOW-6867] Decouple DagBag and TaskInstance

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7488: [AIRFLOW-6867] Decouple DagBag and TaskInstance
URL: https://github.com/apache/airflow/pull/7488#discussion_r382707306
 
 

 ##########
 File path: airflow/models/dagbag.py
 ##########
 @@ -83,7 +82,6 @@ class DagBag(BaseDagBag, LoggingMixin):
     CYCLE_IN_PROGRESS = 1
     CYCLE_DONE = 2
     DAGBAG_IMPORT_TIMEOUT = conf.getint('core', 'DAGBAG_IMPORT_TIMEOUT')
-    UNIT_TEST_MODE = conf.getboolean('core', 'UNIT_TEST_MODE')
     SCHEDULER_ZOMBIE_TASK_THRESHOLD = conf.getint('scheduler', 'scheduler_zombie_task_threshold')
 
 Review comment:
   I don't know. I just do simple refactoring. I don't know the history of this option.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj merged pull request #7488: [AIRFLOW-6867] Decouple DagBag and TaskInstance

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7488: [AIRFLOW-6867] Decouple DagBag and TaskInstance
URL: https://github.com/apache/airflow/pull/7488
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7488: [AIRFLOW-6867] Decouple DagBag and TaskInstance

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7488: [AIRFLOW-6867] Decouple DagBag and TaskInstance
URL: https://github.com/apache/airflow/pull/7488#issuecomment-589792273
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7488?src=pr&el=h1) Report
   > Merging [#7488](https://codecov.io/gh/apache/airflow/pull/7488?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/1a9a9f7618f1c22e3e9a6ef4ec73b717c7760c7d?src=pr&el=desc) will **decrease** coverage by `0.22%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7488/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7488?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7488      +/-   ##
   ==========================================
   - Coverage   86.68%   86.46%   -0.23%     
   ==========================================
     Files         882      883       +1     
     Lines       41526    41634     +108     
   ==========================================
   + Hits        35997    35998       +1     
   - Misses       5529     5636     +107
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7488?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/dagbag.py](https://codecov.io/gh/apache/airflow/pull/7488/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnYmFnLnB5) | `89.74% <ø> (-0.81%)` | :arrow_down: |
   | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7488/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `90.22% <100%> (+0.56%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7488/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7488/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7488/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7488/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.38% <0%> (-25.52%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7488/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...oogle/marketing\_platform/hooks/campaign\_manager.py](https://codecov.io/gh/apache/airflow/pull/7488/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL21hcmtldGluZ19wbGF0Zm9ybS9ob29rcy9jYW1wYWlnbl9tYW5hZ2VyLnB5) | `89.23% <0%> (-10.77%)` | :arrow_down: |
   | [...\_platform/example\_dags/example\_campaign\_manager.py](https://codecov.io/gh/apache/airflow/pull/7488/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL21hcmtldGluZ19wbGF0Zm9ybS9leGFtcGxlX2RhZ3MvZXhhbXBsZV9jYW1wYWlnbl9tYW5hZ2VyLnB5) | `93.93% <0%> (-6.07%)` | :arrow_down: |
   | [airflow/providers/google/cloud/hooks/base.py](https://codecov.io/gh/apache/airflow/pull/7488/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL2Jhc2UucHk=) | `95.9% <0%> (-0.55%)` | :arrow_down: |
   | ... and [15 more](https://codecov.io/gh/apache/airflow/pull/7488/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7488?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7488?src=pr&el=footer). Last update [1a9a9f7...27e572b](https://codecov.io/gh/apache/airflow/pull/7488?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] tooptoop4 commented on issue #7488: [AIRFLOW-6867] Decouple DagBag and TaskInstance

Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #7488: [AIRFLOW-6867] Decouple DagBag and TaskInstance
URL: https://github.com/apache/airflow/pull/7488#issuecomment-589821446
 
 
   @mik-laj there is typo Simpley 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7488: [AIRFLOW-6867] Decouple DagBag and TaskInstance

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7488: [AIRFLOW-6867] Decouple DagBag and TaskInstance
URL: https://github.com/apache/airflow/pull/7488#discussion_r382689833
 
 

 ##########
 File path: airflow/models/dagbag.py
 ##########
 @@ -83,7 +82,6 @@ class DagBag(BaseDagBag, LoggingMixin):
     CYCLE_IN_PROGRESS = 1
     CYCLE_DONE = 2
     DAGBAG_IMPORT_TIMEOUT = conf.getint('core', 'DAGBAG_IMPORT_TIMEOUT')
-    UNIT_TEST_MODE = conf.getboolean('core', 'UNIT_TEST_MODE')
     SCHEDULER_ZOMBIE_TASK_THRESHOLD = conf.getint('scheduler', 'scheduler_zombie_task_threshold')
 
 Review comment:
   Is this still needed in here? Feels like it shouldn't be

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services