You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/04/03 11:50:32 UTC
[GitHub] [incubator-iceberg] chenjunjiedada commented on a change in pull
request #845: Add persistent IDs to partition fields
chenjunjiedada commented on a change in pull request #845: Add persistent IDs to partition fields
URL: https://github.com/apache/incubator-iceberg/pull/845#discussion_r402890960
##########
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##########
@@ -58,14 +58,16 @@
private transient volatile ListMultimap<Integer, PartitionField> fieldsBySourceId = null;
private transient volatile Class<?>[] lazyJavaClasses = null;
private transient volatile List<PartitionField> fieldList = null;
+ private final int lastAssignedFieldId;
Review comment:
Do we want to use TypeUtil::NextID?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org