You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2017/11/08 18:10:57 UTC
[GitHub] spark pull request #19697: [SPARK-22222][CORE][TEST][FOLLOW-UP] Use TimeLimi...
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/19697
[SPARK-22222][CORE][TEST][FOLLOW-UP] Use TimeLimits instead of Timeouts
## What changes were proposed in this pull request?
Since SPARK-21939, Apache Spark uses `TimeLimits` instead of the deprecated `Timeouts`. This PR fixes the build warning `BufferHolderSparkSubmitSuite.scala` introduced at [SPARK-22222](https://github.com/apache/spark/pull/19460/files#diff-d8cf6e0c229969db94ec8ffc31a9239cR36).
```scala
trait Timeouts in package concurrent is deprecated: Please use org.scalatest.concurrent.TimeLimits instead
[warn] with Timeouts {
```
## How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/spark SPARK-22222
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19697.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19697
----
commit 1f17074fc234d62c3babfb3f387ab169e58d61d9
Author: Dongjoon Hyun <do...@apache.org>
Date: 2017-11-08T18:02:10Z
[SPARK-22222][CORE][FOLLOW-UP] Use TimeLimits instead of Timeouts
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19697: [SPARK-22222][CORE][TEST][FOLLOW-UP] Use TimeLimits inst...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19697
**[Test build #83602 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83602/testReport)** for PR 19697 at commit [`1f17074`](https://github.com/apache/spark/commit/1f17074fc234d62c3babfb3f387ab169e58d61d9).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19697: [SPARK-22222][CORE][TEST][FOLLOW-UP] Remove redundant an...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19697
Merged to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19697: [SPARK-22222][CORE][TEST][FOLLOW-UP] Use TimeLimits inst...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19697
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19697: [SPARK-22222][CORE][TEST][FOLLOW-UP] Use TimeLimits inst...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19697
Thanks, @srowen !
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19697: [SPARK-22222][CORE][TEST][FOLLOW-UP] Use TimeLimits inst...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19697
Thanks, @srowen !
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19697: [SPARK-22222][CORE][TEST][FOLLOW-UP] Use TimeLimits inst...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19697
Thanks, @HyukjinKwon .
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19697: [SPARK-22222][CORE][TEST][FOLLOW-UP] Remove redundant an...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19697
Thank you, @HyukjinKwon , @srowen , and @jiangxb1987 .
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19697: [SPARK-22222][CORE][TEST][FOLLOW-UP] Use TimeLimits inst...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19697
**[Test build #83602 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83602/testReport)** for PR 19697 at commit [`1f17074`](https://github.com/apache/spark/commit/1f17074fc234d62c3babfb3f387ab169e58d61d9).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19697: [SPARK-22222][CORE][TEST][FOLLOW-UP] Use TimeLimits inst...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19697
**[Test build #83612 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83612/testReport)** for PR 19697 at commit [`8737bfd`](https://github.com/apache/spark/commit/8737bfdbc1db32db96101d5269a5f386e9b2b5e6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19697: [SPARK-22222][CORE][TEST][FOLLOW-UP] Use TimeLimits inst...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19697
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83612/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19697: [SPARK-22222][CORE][TEST][FOLLOW-UP] Use TimeLimits inst...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19697
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19697: [SPARK-22222][CORE][TEST][FOLLOW-UP] Use TimeLimits inst...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19697
**[Test build #83612 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83612/testReport)** for PR 19697 at commit [`8737bfd`](https://github.com/apache/spark/commit/8737bfdbc1db32db96101d5269a5f386e9b2b5e6).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19697: [SPARK-22222][CORE][TEST][FOLLOW-UP] Use TimeLimits inst...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19697
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83602/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19697: [SPARK-22222][CORE][TEST][FOLLOW-UP] Remove redun...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19697
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org