You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "jbampton (via GitHub)" <gi...@apache.org> on 2025/11/05 12:47:48 UTC
[PR] Add pre-commit with codespell hook [lucenenet]
jbampton opened a new pull request, #1216:
URL: https://github.com/apache/lucenenet/pull/1216
<!-- Thank you for submitting a pull request to our repo. -->
<!-- Please do NOT submit PRs for features in newer versions of Lucene. We should keep the target version consistent across our repository to make the upgrade process to newer versions of Lucene go smoothly. -->
<!-- If this is your first PR in the Lucene.NET repo, please run through the checklist
below to ensure a smooth review and merge process for your PR. -->
- [ ] You've read the [Contributor Guide](https://github.com/apache/lucenenet/blob/master/CONTRIBUTING.md) and [Code of Conduct](https://www.apache.org/foundation/policies/conduct.html).
- [ ] You've included unit or integration tests for your change, where applicable.
- [ ] You've included inline docs for your change, where applicable.
- [ ] There's an open issue for the PR that you are making. If you'd like to propose a change, please [open an issue](https://github.com/apache/lucenenet/issues/new/choose) to discuss the change or find an existing issue.
<!-- Once all that is done, you're ready to go. Open the PR with the content below. -->
Summary of the changes (Less than 80 chars)
Fixes #{issue number} (in this specific format)
## Description
refs #1213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add pre-commit with codespell hook [lucenenet]
Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin commented on code in PR #1216:
URL: https://github.com/apache/lucenenet/pull/1216#discussion_r2551039203
##########
.github/linters/codespell.txt:
##########
@@ -0,0 +1,489 @@
+abl
Review Comment:
This is quite the list of exclusions. Does it need to be this long because of existing spelling errors being too much to fix, or some other reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add pre-commit with codespell hook [lucenenet]
Posted by "NightOwl888 (via GitHub)" <gi...@apache.org>.
NightOwl888 commented on PR #1216:
URL: https://github.com/apache/lucenenet/pull/1216#issuecomment-3491117510
Can we set up an exclude list for specific files or folders?
One thing to be weary of is the fact that we copied all of our test data from Lucene and it should remain unchanged. For example, the `.txt` and `.xml` files here: https://github.com/apache/lucenenet/tree/master/src/Lucene.Net.Tests.Analysis.Common/Analysis/Compound
But it may be simpler if we just exclude every folder that starts with `Lucene.Net.Tests` (or is an exact match) from this tool, since spelling mistakes in test strings may also be intentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add pre-commit with codespell hook [lucenenet]
Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin merged PR #1216:
URL: https://github.com/apache/lucenenet/pull/1216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add pre-commit with codespell hook [lucenenet]
Posted by "jbampton (via GitHub)" <gi...@apache.org>.
jbampton commented on code in PR #1216:
URL: https://github.com/apache/lucenenet/pull/1216#discussion_r2723329309
##########
.github/linters/codespell.txt:
##########
@@ -0,0 +1,489 @@
+abl
Review Comment:
Initially we add pre-commit with a large exclusion list so the test passes.
Then going forwards we can fix some of the spelling in new PRs and regenerate this exclusion list.
So as we fix spelling the list will get smaller.
Some of the words in the exclusion list are false positives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add pre-commit with codespell hook [lucenenet]
Posted by "jbampton (via GitHub)" <gi...@apache.org>.
jbampton commented on PR #1216:
URL: https://github.com/apache/lucenenet/pull/1216#issuecomment-3491124807
Yes we can exclude files and folders. I will add the exclude now for `Lucene.Net.Tests`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org