[jira] [Commented] (ARTEMIS-794) AMQP: Modified and Rjected Outcomes are not being handled correctly

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856006#comment-15856006 ] 

ASF subversion and git services commented on ARTEMIS-794:
---------------------------------------------------------

Commit b9bf5d54f25f08bcd692efb2d3f81c4373f53807 in activemq-artemis's branch refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=b9bf5d5 ]

ARTEMIS-794 Add tests for handling of various outcomes for deliveries

Adds tests for handling of Rejected, Released and Modified outcomes for
a delivery sent to a receiver.  Tests show that for the Modified outcome
the broker is redelivering the message to the same receiver when the
undeliverable here value is set which violates the AMQP 1.0 specified
handling of that field.  Also for Rejected outcome the broker should
be sending the rejected message to the DLQ as Rejected is supposed to
be a terminal outcome.

Small fix included to not adjust the delivery count if the Modified
outcome does not indicate that the delivery failed.


> AMQP: Modified and Rjected Outcomes are not being handled correctly
> -------------------------------------------------------------------
>
>                 Key: ARTEMIS-794
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-794
>             Project: ActiveMQ Artemis
>          Issue Type: Task
>          Components: AMQP
>    Affects Versions: 1.4.0
>            Reporter: Timothy Bish
>            Priority: Blocker
>             Fix For: 2.0.0
>
>
> The Modified outcome when sent has certain constraints placed on how the broker should handle it.  If the outcome indicates the delivery failed the remote must increment the delivery count, otherwise it should not.  If the outcome indicates that the message is "undeliverable here" than the remote must not send the message back to the modifying link.  (Note that in 5.x we treat the undeliverable here value as a cause to DLQ the message in order to ensure we don't redeliver it again to the link that modified it)
> The Rejected Outcome is meant to be a terminal outcome and the message should transition to the Archived state which would amount to be sent to the DLQ in Artemis.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)