[jira] [Issue Comment Edited] (WICKET-4357) Calling WebResponse#enableCaching() is insufficient to enable caching on WebPage (which by default is non-cacheable)

["Peter Ertl (Issue Comment Edited) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-4357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193267#comment-13193267 ] 

Peter Ertl edited comment on WICKET-4357 at 1/25/12 8:03 PM:
-------------------------------------------------------------

Actually the javadoc on WebPage#setHeaders is pretty straightforward on this issue. Nevertheless I added a link to this jira ticket in the javadoc for #enableCaching which will potentially save some people's time :-)
                
      was (Author: pete):
    Actually the javadoc on WebPage#setHeaders is pretty straightforward on this. Nevertheless I added a link to this jira ticket in the javadoc for #enableCaching and potentially save some people's time :-)
                  
> Calling WebResponse#enableCaching() is insufficient to enable caching on WebPage (which by default is non-cacheable)
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4357
>                 URL: https://issues.apache.org/jira/browse/WICKET-4357
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.4, 6.0.0
>            Reporter: Michael Allan
>            Assignee: Peter Ertl
>            Priority: Minor
>              Labels: cache
>             Fix For: 1.5.5, 6.0.0
>
>
> WebResponse.enableCaching() is documented to enable caching, but it does not.  You must also override WebPage.setHeaders(), otherwise it clobbers the headers by calling disableCaching().
> The API docs for WebResponse.enableCaching() should be clear about this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira