You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "TherChenYang (via GitHub)" <gi...@apache.org> on 2024/07/03 05:49:42 UTC

Re: [PR] verify the functions involved in #31562 and add test cases #31562 [shardingsphere]

TherChenYang commented on code in PR #31928:
URL: https://github.com/apache/shardingsphere/pull/31928#discussion_r1663524256


##########
test/it/parser/src/main/resources/case/dml/select-special-function.xml:
##########
@@ -1242,4 +1242,163 @@
             </expression-projection>
         </projections>
     </select>
+
+    <select sql-case-id="select_row_number">
+        <projections start-index="7" stop-index="25">
+            <expression-projection text="ROW_NUMBER() OVER w" start-index="7" stop-index="25">
+                <expr>
+                    <function function-name="ROW_NUMBER" start-index="7" stop-index="25" text="ROW_NUMBER() OVER w" />
+                </expr>
+                <window start-index="22" stop-index="34">
+                    <window-item start-index="27" stop-index="34">
+                        <order-by>
+                            <column-item name="user_id" order-direction="ASC" start-index="32" stop-index="34"/>

Review Comment:
   Where does the user_id column come from? I did not find this field in SQL 
   ```sql
   SELECT ROW_NUMBER() OVER w FROM t_order
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org