You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/07/29 02:23:26 UTC
Review Request 36899: Updated MesosZooKeeperTest to avoid side
effects.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36899/
-----------------------------------------------------------
Review request for mesos and Marco Massenzio.
Bugs: MESOS-3168
https://issues.apache.org/jira/browse/MESOS-3168
Repository: mesos
Description
-------
Added SetUp() and TearDown() functions that make sure ZK server is restarted for every test to avoid side effects.
Diffs
-----
src/tests/mesos.hpp 7538c96bf4037b7b7c13e80a1f12bbe69ce775cc
Diff: https://reviews.apache.org/r/36899/diff/
Testing
-------
make check
Also tested with Marco's patch in https://reviews.apache.org/r/36807/
Thanks,
Vinod Kone
Re: Review Request 36899: Updated MesosZooKeeperTest to avoid side
effects.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36899/#review93420
-----------------------------------------------------------
src/tests/mesos.hpp (line 294)
<https://reviews.apache.org/r/36899/#comment147788>
Remove startNetwork() here?
- haosdent huang
On July 29, 2015, 12:23 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36899/
> -----------------------------------------------------------
>
> (Updated July 29, 2015, 12:23 a.m.)
>
>
> Review request for mesos and Marco Massenzio.
>
>
> Bugs: MESOS-3168
> https://issues.apache.org/jira/browse/MESOS-3168
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added SetUp() and TearDown() functions that make sure ZK server is restarted for every test to avoid side effects.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 7538c96bf4037b7b7c13e80a1f12bbe69ce775cc
>
> Diff: https://reviews.apache.org/r/36899/diff/
>
>
> Testing
> -------
>
> make check
>
> Also tested with Marco's patch in https://reviews.apache.org/r/36807/
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 36899: Updated MesosZooKeeperTest to avoid side
effects.
Posted by Marco Massenzio <ma...@mesosphere.io>.
> On July 29, 2015, 12:25 a.m., Marco Massenzio wrote:
> > Ship It!
as they say, hindsight is 20/20 :)
Thanks for the deep investigative work!
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36899/#review93371
-----------------------------------------------------------
On July 29, 2015, 12:23 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36899/
> -----------------------------------------------------------
>
> (Updated July 29, 2015, 12:23 a.m.)
>
>
> Review request for mesos and Marco Massenzio.
>
>
> Bugs: MESOS-3168
> https://issues.apache.org/jira/browse/MESOS-3168
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added SetUp() and TearDown() functions that make sure ZK server is restarted for every test to avoid side effects.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 7538c96bf4037b7b7c13e80a1f12bbe69ce775cc
>
> Diff: https://reviews.apache.org/r/36899/diff/
>
>
> Testing
> -------
>
> make check
>
> Also tested with Marco's patch in https://reviews.apache.org/r/36807/
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 36899: Updated MesosZooKeeperTest to avoid side
effects.
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36899/#review93371
-----------------------------------------------------------
Ship it!
Ship It!
- Marco Massenzio
On July 29, 2015, 12:23 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36899/
> -----------------------------------------------------------
>
> (Updated July 29, 2015, 12:23 a.m.)
>
>
> Review request for mesos and Marco Massenzio.
>
>
> Bugs: MESOS-3168
> https://issues.apache.org/jira/browse/MESOS-3168
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added SetUp() and TearDown() functions that make sure ZK server is restarted for every test to avoid side effects.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 7538c96bf4037b7b7c13e80a1f12bbe69ce775cc
>
> Diff: https://reviews.apache.org/r/36899/diff/
>
>
> Testing
> -------
>
> make check
>
> Also tested with Marco's patch in https://reviews.apache.org/r/36807/
>
>
> Thanks,
>
> Vinod Kone
>
>