You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/01/09 17:44:14 UTC
[GitHub] [couchdb] davisp opened a new pull request #2434: Feat/improve
javascript test reports
davisp opened a new pull request #2434: Feat/improve javascript test reports
URL: https://github.com/apache/couchdb/pull/2434
## Overview
This PR adds a JUnit compatible test report for JavaScript tests and includes the output of `build-aux/show-test-results.py` in the uploaded logs when builds fail. This will hopefully allow us to improve our ability to debug flaky tests.
## Testing recommendations
`make check`
## Checklist
- [x] Code is written and works correctly
- [ ] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] kocolosk commented on a change in pull request #2434:
Feat/improve javascript test reports
Posted by GitBox <gi...@apache.org>.
kocolosk commented on a change in pull request #2434: Feat/improve javascript test reports
URL: https://github.com/apache/couchdb/pull/2434#discussion_r364877246
##########
File path: build-aux/logfile-uploader.py
##########
@@ -62,7 +65,7 @@ def build_ci_doc():
doc["commit"] = os.environ["TRAVIS_COMMIT"]
doc["repo"] = "https://github.com/" + os.environ["TRAVIS_REPO_SLUG"]
elif "JENKINS_URL" in os.environ:
- doc["builder"] = "jenkins"
+ doc["builder"] = "jenk-ins"
Review comment:
To avoid the *****?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] davisp commented on a change in pull request #2434:
Feat/improve javascript test reports
Posted by GitBox <gi...@apache.org>.
davisp commented on a change in pull request #2434: Feat/improve javascript test reports
URL: https://github.com/apache/couchdb/pull/2434#discussion_r364883785
##########
File path: build-aux/Jenkinsfile.full
##########
@@ -22,7 +22,7 @@ cd build
tar -xf ${WORKSPACE}/apache-couchdb-*.tar.gz
cd apache-couchdb-*
./configure --with-curl --spidermonkey-version ${sm_ver}
-make check || (build-aux/logfile-uploader.py && false)
+make check || (make build-reports && false)
Review comment:
Derp. Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] davisp merged pull request #2434: Feat/improve javascript
test reports
Posted by GitBox <gi...@apache.org>.
davisp merged pull request #2434: Feat/improve javascript test reports
URL: https://github.com/apache/couchdb/pull/2434
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] davisp commented on a change in pull request #2434:
Feat/improve javascript test reports
Posted by GitBox <gi...@apache.org>.
davisp commented on a change in pull request #2434: Feat/improve javascript test reports
URL: https://github.com/apache/couchdb/pull/2434#discussion_r364882801
##########
File path: build-aux/logfile-uploader.py
##########
@@ -62,7 +65,7 @@ def build_ci_doc():
doc["commit"] = os.environ["TRAVIS_COMMIT"]
doc["repo"] = "https://github.com/" + os.environ["TRAVIS_REPO_SLUG"]
elif "JENKINS_URL" in os.environ:
- doc["builder"] = "jenkins"
+ doc["builder"] = "jenk-ins"
Review comment:
Yap
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] kocolosk commented on a change in pull request #2434:
Feat/improve javascript test reports
Posted by GitBox <gi...@apache.org>.
kocolosk commented on a change in pull request #2434: Feat/improve javascript test reports
URL: https://github.com/apache/couchdb/pull/2434#discussion_r364876662
##########
File path: build-aux/Jenkinsfile.full
##########
@@ -22,7 +22,7 @@ cd build
tar -xf ${WORKSPACE}/apache-couchdb-*.tar.gz
cd apache-couchdb-*
./configure --with-curl --spidermonkey-version ${sm_ver}
-make check || (build-aux/logfile-uploader.py && false)
+make check || (make build-reports && false)
Review comment:
the target is `build-report` not `build-reports`, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services