You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by ilganeli <gi...@git.apache.org> on 2016/05/24 21:39:00 UTC
[GitHub] incubator-apex-core pull request: Update code style structure and ...
GitHub user ilganeli opened a pull request:
https://github.com/apache/incubator-apex-core/pull/341
Update code style structure and docs
* Importing code style settings was confusing because it wasn't obvious from the documentation where specific files resided.
* Renamed the .settings folder to settings. This is done since on Mac OSX, by default hidden folders are not visible, thus importing these settings into your IDE is impossible without changing system configuration (undesirable).
* Updated documentation to reflect this renaming.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilganeli/incubator-apex-core UpdateCodeStyleStructureAndDocs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/341.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #341
----
commit db79cf462de3342281948dbe6fdcb640e593fc32
Author: Ilya Ganelin <il...@capitalone.com>
Date: 2016-05-24T21:26:52Z
Updated README to be more clear about location of code style settings. Updated eclipse settings to be consistent with Netbeans and IntelliJ.
commit eecb3450c8431a19ab1d8ff1d174d5873222b43f
Author: Ilya Ganelin <il...@capitalone.com>
Date: 2016-05-24T21:32:07Z
Renamed .settings to settings to support file import on native Mac OS configurations.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: Update code style structure and ...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/341#issuecomment-221642311
Ilya, you should find that discussion on the mailing list. The issue was that the binary files were included into the release. There were several options discussed, one was to move these settings out of the source tree altogether. There was also another discussion about the need for those in first place. Intellij actually has settings under .idea checked in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: Update code style structure and ...
Posted by ilganeli <gi...@git.apache.org>.
Github user ilganeli closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/341
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: Update code style structure and ...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/341#issuecomment-221614217
Please submit the PR so that it contains all your changes as single commit and not other commits:
http://apex.apache.org/contributing.html
Regarding the directory name, we cannot change this. Please inspect the history as that explains why the change was made a while ago.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: Update code style structure and ...
Posted by ilganeli <gi...@git.apache.org>.
Github user ilganeli commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/341#issuecomment-221639315
@tweise Based on the commit hash from the history, the change to ".settings" is only referenced in this PR:
https://github.com/apache/incubator-apex-core/pull/314
In that PR, it's complete unclear why this change was made (it's one of over 300 other commits). Is there any other discussion explaining this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---